Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update SDK constraints, dependencies, and Gradle configuration… #354

Merged

Conversation

berhili098
Copy link
Contributor

@berhili098 berhili098 commented Jan 6, 2025

This pull request includes several updates and improvements to the Flutter example project. The changes primarily focus on updating configuration files, improving project metadata, and refining Android build settings.

Configuration and Metadata Updates:

  • Added a new run configuration for main.dart in the .idea directory (example/.idea/runConfigurations/main_dart.xml).
  • Updated the .metadata file to include new migration tracking information and adjusted the version details (example/.metadata).

Analysis and Linting:

  • Introduced an analysis_options.yaml file to configure the Dart analyzer with recommended lints for Flutter projects (example/analysis_options.yaml).

Android Build and Manifest Changes:

  • Refactored build.gradle to use plugins and updated SDK versions and configurations (example/android/app/build.gradle).
  • Enhanced Android manifest files by adding necessary permissions and updating application settings (example/android/app/src/main/AndroidManifest.xml). [1] [2] [3]

These changes collectively improve the project setup, ensure better code quality through linting, and optimize the Android build configuration.

Copy link
Contributor Author

@berhili098 berhili098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queendevelopers Could you please take a look at this PR and share your feedback when you have a moment? Thank you!

@queendevelopers
Copy link
Collaborator

@queendevelopers Could you please take a look at this PR and share your feedback when you have a moment? Thank you!

Could you please address the lint warnings? Thank you!

@berhili098
Copy link
Contributor Author

@queendevelopers Could you please take a look at this PR and share your feedback when you have a moment? Thank you!

Could you please address the lint warnings? Thank you!

I also added some rules and resolved their associated warnings.

Copy link
Collaborator

@queendevelopers queendevelopers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid making all file changes in a single PR, as it makes the review process more difficult. Instead, create multiple PRs for different fixes to make it easier for maintainers to review. For this PR, kindly keep only the example changes and revert any other changes outside of that. Please create separate PRs for those. Thank you!

@berhili098
Copy link
Contributor Author

berhili098 commented Jan 11, 2025

Please avoid making all file changes in a single PR, as it makes the review process more difficult. Instead, create multiple PRs for different fixes to make it easier for maintainers to review. For this PR, kindly keep only the example changes and revert any other changes outside of that. Please create separate PRs for those. Thank you!

When I updated the lints and Flutter, it triggered several lint issues across the project, which I had to address to ensure the build would pass. Additionally, the Flutter update required me to update the Gradle version, which further necessitated migrating to Gradle 8.3 to maintain compatibility.

If you'd prefer, I can try separating these changes into multiple PRs, but they are interconnected and may not function independently without the full set of updates. Please let me know how you'd like me to proceed. Thank you!

Copy link
Collaborator

@queendevelopers queendevelopers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review following comments. Thank you!

…r handling and consistency; downgrade SDK version for broader compatibility
…tibility; refactor MyHomePage constructor for null safety
@queendevelopers queendevelopers merged commit 55d308c into aagarwal1012:master Jan 18, 2025
2 of 3 checks passed
@berhili098 berhili098 deleted the update/gradle-and-dependencies branch January 18, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants