[bigfix] fix panics from clap internal type casting
#1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops I didn't notice until now that I did all of this just to be a duplicate of #1233. That said I believe my PR is more robust as it handles panics in more than just the |
JackDyre
changed the title
clap internal type castingclap internal type casting
|
Oops I just noticed this PR is also a duplicate of #1209. Smh I need to do better investiagtion. I still believe my implementation is better as per my comment about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1236
Any CLI flags that are constructed with the
.value_parser(["slice", "of", "possible", "values"])would cause clap to panic due to a type casting error whenever parsed into any type other thanString, (even&str).The best solution is to parse to a
Stringand map it to parse it further. Thevalue_parser!()macro is more concise and allows clap to parse to the type specified, but you lose the error message that tells the user the possible values to pass to the flag.Tests pass
A follow-up PR that adds test coverage to the CLI flags might be a good idea so this doesn't happen again.