Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sha is optional in DiffEntry if file contents are unchanged #750

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sha is optional in DiffEntry if file contents are unchanged #750

wants to merge 1 commit into from

Conversation

fiadliel
Copy link

@fiadliel fiadliel commented Feb 1, 2025 •
edited
Loading

When only metadata changes for a file, the sha field is null when requesting a commit. An example of this is if the file mode was changed.

This behavior is different from what the online documentation says, which is that this is a required field.

Fixes: #749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commits may fail to be deserialized because sha field may be null in DiffEntry if contents did not change
1 participant
@fiadliel