-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal: Support scrolling entire modal / overlay for overflowing content. #790
Labels
Comments
...And once the user's browser is medium or small size, even the short content on Home needs a scrollbar. |
This was referenced Aug 17, 2020
Closed
6 tasks
Once #962 is complete, this will be unblock - Waiting on v5 release |
In v5, the following is needed: https://codesandbox.io/s/405x1 Here's an example of content scroll instead: https://codesandbox.io/s/kwuj2 The 2 codesandboxes were created based off #905 |
NicholasBoll
added a commit
to NicholasBoll/canvas-kit
that referenced
this issue
Sep 10, 2021
This was referenced Sep 10, 2021
NicholasBoll
added a commit
to NicholasBoll/canvas-kit
that referenced
this issue
Jan 15, 2022
workday-canvas-kit
pushed a commit
that referenced
this issue
Jan 26, 2022
Fixes #790 This PR changes the structure of Modals slightly by removing the extra `div` in the `Modal.Body` and `Popup.Body` and instead adds the type that `Card.Body` adds manually. This allows the `Modal.Body` to be more easily styled, but may be a breaking change. This change also allows overflow to be applied to Modals. [category:Components]
Fixed in v7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 Feature Proposal
For modals with a large amount of content that will not fit on the screen, it would be nice to have an option for the overlay itself to scroll (as opposed to always requiring the consumer to make the content of the modal itself scrollable).
An additional requirement of this feature would be that the background content should not be scrollable while the modal is open. This would also likely be useful even for modals that handle scrolling within their content.
Motivation
Currently on PEX we have several use cases for modals where the content is user defined, and can be quite large. For example, on the Home page, we have modals for announcements that are user configured and can contain media and rich text. Likewise is true for Knowledge Base articles which can be shown in modals in many places and are almost always larger than will fit on screen at any resolution.
Example
The text was updated successfully, but these errors were encountered: