Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing should be skipped for plugins not related to changes in a pull request #1792

Open
westonruter opened this issue Jan 12, 2025 · 0 comments · May be fixed by #1838
Open

Unit testing should be skipped for plugins not related to changes in a pull request #1792

westonruter opened this issue Jan 12, 2025 · 0 comments · May be fixed by #1838
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@westonruter
Copy link
Member

Feature Description

When opening a pull request that changes files to one plugin, only the unit tests for that plugin should run. This will greatly speed up our workflows (and reduce wasted compute), especially now that code coverage is being performed. That said, would it be problematic if PRs didn't include coverage reports for all plugins?

Note that a PR that modifies Optimization Detective should also cause the tests for Embed Optimizer and Image Prioritizer to also run, since they are dependent on that plugin.

Naturally, all tests would run for all plugins for commits added to trunk.

This has been suggested before by @thelovekesh, but I don't remember where.

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Jan 12, 2025
@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2024 Jan 12, 2025
@ShyamGadde ShyamGadde linked a pull request Jan 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Status: Not Started/Backlog 📆
Development

Successfully merging a pull request may close this issue.

1 participant