Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old URLs to new path-based URLs #69585

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Mar 16, 2025

Closes: #69584

What?

What?

Update old URL parameters to align with the site editor's current path-based URL structure.

Why?

Currently, the site editor references the p GET parameter to determine which page to show, but there are still some URLs using old parameters (path, etc.).

How?

Updated the URL query parameter from path: '/patterns' to p: '/pattern' in three files:

  • packages/edit-post/src/components/more-menu/manage-patterns-menu-item.js
  • packages/patterns/src/components/patterns-manage-button.js
  • packages/reusable-blocks/src/components/reusable-blocks-menu-items/reusable-blocks-manage-button.js

Testing Instructions

  1. Open the WordPress editor for a post or page
  2. Click on the "More" menu (three dots in the top right)
  3. Click on the "Manage patterns" option
  4. Verify you are correctly taken to the patterns page

Screencast

Screen.Recording.2025-03-17.at.12.35.40.PM.mov
Screen.Recording.2025-03-17.at.12.35.10.PM.mov
Screen.Recording.2025-03-17.at.12.34.17.PM.mov

@Infinite-Null Infinite-Null marked this pull request as ready for review March 18, 2025 06:46
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka requested review from Mamaduka and t-hamano March 18, 2025 08:18
@Mamaduka Mamaduka added the [Type] Code Quality Issues or PRs that relate to code quality label Mar 18, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Mar 18, 2025
@t-hamano t-hamano merged commit 9649c59 into WordPress:trunk Mar 18, 2025
68 of 70 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.6 milestone Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Editor: Update old URLs to new path-based URLs
3 participants