Include blocks manifest build process in Webpack config to fix create-block bug with missing blocks manifest file
#69578
+50
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… blocks manifest file.
felixarntz
added
[Type] Bug
felixarntz
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @samikeijonen. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in cc80415. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13860341130
|
6 tasks
|
I contributed one enhancement d01a653 that wasn't working in my testing - a custom output path provided for the build commands, example: wp-scripts start --blocks-manifest --output-path=dist |
gziolo
reviewed
Mar 18, 2025
| apply( compiler ) { | ||
| compiler.hooks.afterEmit.tap( 'BlocksManifest', () => { | ||
| exec( | ||
| `node ${ fromScriptsRoot( |
There was a problem hiding this comment.
I changed here two things in d01a653.
- Use the local script rather than
wp-scriptsexecutable so it can run locally in non-standard way. The way I usually test changes is by running../node_modules/.bin/wp-scripts start --blocks-manifest --output-path=distfrom the scaffolded block without the npm packages installed. This way I can use the latest version ofwp-scriptsfrom the Gutenberg repository. - I added a way to change the
--inputparam in the case when someone decides the build folder should live in a different location.
There was a problem hiding this comment.
Thanks for these fixes!
gziolo
approved these changes
Mar 18, 2025
t-hamano
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Can we update CHANGELOG.md and README.md and add a description of the new argument?
Probably around here:
gutenberg/packages/scripts/README.md
Lines 89 to 93 in 5f28621
gutenberg/packages/scripts/README.md
Lines 423 to 430 in 5f28621
|
@t-hamano I'm on vacation right now, so please feel free to amend this PR directly as needed. Looks like it's almost good to go, and +1 to documenting the new argument. |
|
Updated changelog and readme via 8cc1b0f |
|
I ask myself to know if the guys that are maintaining the @wordpress/create-block packages are aware of that? Could they simply update the packages for the scripts behave normally ???? |
|
@liothub Could you explain your question in a bit more detail? |
Is it normal that blocks-manifest.php be deleted with npm start ? No.... Then, it's denote a problem into the scripts.... a bug, a typo elsewhere.... The scripts are intended to work properly without having to hack them every two days... doesn't you agree?? |
|
Sorry, I'm not sure what you're asking. Do you mean that there is still a problem to be fixed in either |
The problem stays the same: npm start delete the blocks-manifest.php file which seats normaly into the build directory Its not a normal situation which have to be solved by the scripts developers Today's morning 10:00 AM in France, I install the script and there is still the problem... the version of the moment is I'm waiting for the new 'corrected' version :-) |
|
We should see the updated version of both packages |
Thanks !!! We can check here, I guess |
|
For now, for anyone reading and needing a simple solution until fix gets released: For Mac/Linux
For windows
Also in your-block-name.php replace under What this will do is to put the blocks-manifest.php in a dir folder and doesn't get deleted when using the |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69565
How?
wp-scripts build-blocks-manifestas part of Webpack process if--blocks-manifestargument is present.create-block's generatedpackage.jsonto use that new--blocks-manifestargument instead of separately callingwp-scripts build-blocks-manifestwhich does not play well together with Webpack's own watch mode.Important: These changes affect
@wordpress/scriptsand@wordpress/create-block, and ideally both packages are released with these changes at the same time.That's because the
create-blockchange depends on thescriptschange.Testing Instructions
See #69565.