Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Nested list indendation in editor for classic themes #69507

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix: Nested list indendation in editor for classic themes #69507

wants to merge 1 commit into from
+1 −1

Conversation

karthikeya-io
Copy link

@karthikeya-io karthikeya-io commented Mar 10, 2025 •
edited
Loading

What?

Closes #69503
Related https://wordpress.org/support/topic/list-block-no-visual-nested-indent/

Why?

Fix nested list indentation in editor for classic themes.

How?

Prevents applying margin-left:auto and margin-right: auto to nested lists

Testing Instructions

  1. Activate Twenty Fifteen.
  2. Create a new post and add a list block.
  3. Add multiple list item and indent them with different depths.
  4. Confirm that the nested list items are visually indented as expected.

Testing Instructions for Keyboard

Same

Screenshots or screencast

Before After
image image

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 10, 2025
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthikeya-io! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@karthikeya-io karthikeya-io force-pushed the fix/classic-theme-indent-nested-list branch from 30cb460 to f45e008 Compare March 10, 2025 11:42
@karthikeya-io karthikeya-io marked this pull request as ready for review March 10, 2025 12:25
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthikeya-io <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@rey rey mentioned this pull request Mar 17, 2025
Open
6 tasks
@carolinan carolinan added [Block] List Affects the List Block [Type] Bug An existing feature does not function as intended labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Block] List Affects the List Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Classic themes: Default block margins are overriding the list block
2 participants
@karthikeya-io @carolinan