[INCOMPLETE] Shell scripts: various tweaks

Various tweaks to allow the scripts to pass the shellcheck checks.

Author: jrfnl

Diff for: tests/utils/proxy/start.sh

@@ -5,15 +5,15 @@ PORT=${PORT:-9000}
 
 PROXYBIN=${PROXYBIN:-"$(which mitmdump)"}
 ARGS="-s '$PROXYDIR/proxy.py' -p $PORT"
-if [[ ! -z "$AUTH" ]]; then
+if [[ -n "$AUTH" ]]; then
 	ARGS="$ARGS --proxyauth $AUTH"
 fi
 PIDFILE="$PROXYDIR/proxy-$PORT.pid"
 
 set -x
 
-start-stop-daemon --verbose --start --background --pidfile $PIDFILE --make-pidfile --exec $PROXYBIN -- $ARGS
+start-stop-daemon --verbose --start --background --pidfile "$PIDFILE" --make-pidfile --exec "$PROXYBIN" -- $ARGS
 
-ps -p $(cat $PIDFILE) u
+ps -p "$(cat "$PIDFILE")" u
 sleep 2
-ps -p $(cat $PIDFILE) u
+ps -p "$(cat "$PIDFILE")" u

Diff for: tests/utils/proxy/stop.sh

@@ -1,10 +1,10 @@
 #!/usr/bin/env bash
 
-PROXYDIR="$PWD/$(dirname $0)"
+PROXYDIR="$PWD/$(dirname "$0")"
 PORT=${PORT:-9000}
 
 PIDFILE="$PROXYDIR/proxy-$PORT.pid"
 
 set -x
 
-start-stop-daemon --verbose --stop --pidfile $PIDFILE --remove-pidfile
+start-stop-daemon --verbose --stop --pidfile "$PIDFILE" --remove-pidfile