v2 to v4 upload-artifact updates

Author: JohnLangford

.github/workflows/backward_model_load_check.yml

@@ -60,7 +60,7 @@ jobs:
           pip install built_wheel/*.whl
           python ./test/run_tests_model_gen_and_load.py --generate_models --skip_missing_args --skip_pr_tests "${{ github.event.pull_request.title }}"
       - name: Upload generated file
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: vw_generated_models
           path: ~/.vw_runtests_model_gen_working_dir/*

.github/workflows/forward_model_load_check.yml

@@ -57,7 +57,7 @@ jobs:
           pip install built_wheel/*.whl
           python ./test/run_tests_model_gen_and_load.py --generate_models --skip_pr_tests "${{ github.event.pull_request.title }}"
       - name: Upload generated file
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: vw_generated_models
           path: ~/.vw_runtests_model_gen_working_dir/*

.github/workflows/python_wheels.yml

@@ -103,7 +103,7 @@ jobs:
         shell: bash
         run: python setup.py sdist
       - name: Upload built wheel
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: python_source_distribution
           path: dist/*.tar.gz

.github/workflows/run_benchmarks_manual.yml

@@ -29,7 +29,7 @@ jobs:
         shell: bash
         run: cp ./.scripts/linux/*benchmarks.sh test/benchmarks/
       - name: Upload benchmark module
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: benchmark-module
           path: test/benchmarks/
@@ -63,13 +63,13 @@ jobs:
         shell: bash
         run: ./.scripts/linux/run-benchmarks.sh base-benchmarks.json
       - name: Upload ${{ github.event.inputs.base_ref }} benchmark results
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: base-benchmarks
           path: base-benchmarks.json
           if-no-files-found: error
       - name: Upload benchmark compare
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: benchmark-compare
           path: benchmark/tools/

.github/workflows/valgrind.yml

@@ -24,19 +24,19 @@ jobs:
           cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DBUILD_EXPERIMENTAL_BINDING=On -DVW_FEAT_FLATBUFFERS=On -DVW_FEAT_CSV=On -DVW_FEAT_CB_GRAPH_FEEDBACK=On -DSTD_INV_SQRT=ON
           cmake --build build
       - name: Upload vw binary
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: vw
           path: build/vowpalwabbit/cli/vw
           if-no-files-found: error
       - name: Upload spanning_tree binary
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: spanning_tree
           path: build/vowpalwabbit/spanning_tree_bin/spanning_tree
           if-no-files-found: error
       - name: Upload to_flatbuff binary
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: to_flatbuff
           path: build/utl/flatbuffer/to_flatbuff