Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Missing or incorrect absmax2 handling in q_galore_adamw8bit.py #10

Open
LLMresearcher opened this issue Jan 13, 2025 · 0 comments
Open

Comments

@LLMresearcher
Copy link

When using the 8-bit AdamW optimizer in q_galore_adamw8bit.py, optimizer_update_8bit_blockwise() requires absmax2 but it is not defined. Seems like absmax2 expects passing a tensor.

[rank0]: File "/root/Q-GaLore/q_galore_torch/q_galore_adamw8bit.py", line 200, in update_step
[rank0]: F.optimizer_update_8bit_blockwise(
[rank0]: TypeError: optimizer_update_8bit_blockwise() missing 1 required positional argument: 'absmax2'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant