Skip to content
This repository has been archived by the owner on Sep 17, 2021. It is now read-only.

Doesn’t woks with ᴇʀᴄ20 tokens which always returns nothing. #38

Open
ytrezq opened this issue Aug 19, 2019 · 1 comment
Open

Doesn’t woks with ᴇʀᴄ20 tokens which always returns nothing. #38

ytrezq opened this issue Aug 19, 2019 · 1 comment

Comments

@ytrezq
Copy link

ytrezq commented Aug 19, 2019

Not that Vyper uses RETURNDATASIZE, but the used memory location for returning data always contains nothing…

This results in the same as https://medium.com/coinmonks/missing-return-value-bug-at-least-130-tokens-affected-d67bf08521ca
@ytrezq ytrezq changed the title Doesn’t woks with ᴇʀᴄ20 tokens which returns nothing. Doesn’t woks with ᴇʀᴄ20 tokens which always returns nothing. Aug 19, 2019
@wjmelements
Copy link

If it returns nothing it is not erc20. ERC20 requires that transferFrom and transfer return bool.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wjmelements @ytrezq