You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
As is widely known at this point, Uniswap is not safe to use with ERC-777 tokens (even if you are only using the ERC-20 interface). More broadly speaking, the Uniswap contracts incorrectly assume that the token contract being called will not call out into any third party (potentially trader-controlled) code prior to returning.
Uniswap vNext should address this issue.
The text was updated successfully, but these errors were encountered:
While I disagree that tokens that call into the recipient are inherently unsafe, I don't think that is relevant here since Uniswap cannot dictate how tokens function internally. Since Uniswap supports arbitrary tokens (one of its biggest selling points!), I think it needs to assume the worst and that the token will do all of the worst things possible when called.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As is widely known at this point, Uniswap is not safe to use with ERC-777 tokens (even if you are only using the ERC-20 interface). More broadly speaking, the Uniswap contracts incorrectly assume that the token contract being called will not call out into any third party (potentially trader-controlled) code prior to returning.
Uniswap vNext should address this issue.
The text was updated successfully, but these errors were encountered: