Change app/Dockerfile to use ubuntu:focal, ignore some special cases following the pylint warning guide to fix CI/CD pylint test.

Author: luvwinnie

app/Dockerfile

@@ -1,4 +1,4 @@
-FROM ubuntu:18.04
+FROM ubuntu:focal
 
 COPY requirements.txt requirements.txt
 

app/plot_app/config.py

@@ -2,7 +2,7 @@
 import configparser
 import os
 
-#pylint: disable=bad-whitespace, invalid-name
+#pylint: disable=invalid-name
 
 # load the config
 _conf = configparser.ConfigParser()

app/plot_app/helper.py

@@ -318,7 +318,7 @@ def load_ulog_file(file_name):
     # catch all other exceptions and turn them into an ULogException
     except Exception as error:
         traceback.print_exception(*sys.exc_info())
-        raise ULogException()
+        raise ULogException() from error
 
     # filter messages with timestamp = 0 (these are invalid).
     # The better way is not to publish such messages in the first place, and fix

app/plot_app/pid_analysis_plots.py

@@ -116,7 +116,7 @@ def _resample(time_array, data, desired_time):
                                       [time_controls[0], time_controls[-1]])
 
         p = data_plot.bokeh_plot
-        p.patch(time_controls, thrust, line_width=0, fill_color='#555555',
+        p.patch(time_controls, thrust, line_width=0, fill_color='#555555', # pylint: disable=too-many-function-args
                 fill_alpha=0.4, alpha=0, legend_label='Thrust [0, {:}]'.format(thrust_max))
 
         data_plot.change_dataset(rate_topic_name)

app/plot_app/plotting.py

@@ -732,7 +732,7 @@ def __init__(self, data, config, data_name, x_axis_label=None,
                  y_axis_label=None, title=None, plot_height='normal',
                  equal_aspect=True):
 
-        super(DataPlot2D, self).__init__(data, config, data_name,
+        super().__init__(data, config, data_name,
                                          x_axis_label=x_axis_label,
                                          y_axis_label=y_axis_label,
                                          title=title, plot_height=plot_height)
@@ -796,7 +796,7 @@ def __init__(self, data, config, data_name, x_axis_label=None,
                  y_axis_label=None, title=None, plot_height='small',
                  x_range=None, y_range=None, topic_instance=0):
 
-        super(DataPlotSpec, self).__init__(data, config, data_name, x_axis_label=x_axis_label,
+        super().__init__(data, config, data_name, x_axis_label=x_axis_label,
                                            y_axis_label=y_axis_label, title=title, plot_height=plot_height,
                                            x_range=x_range, y_range=y_range, topic_instance=topic_instance)
 
@@ -898,7 +898,7 @@ def __init__(self, data, config, data_name,
                  title=None, plot_height='small',
                  x_range=None, y_range=None, topic_instance=0):
 
-        super(DataPlotFFT, self).__init__(data, config, data_name, x_axis_label='Hz',
+        super().__init__(data, config, data_name, x_axis_label='Hz',
                                           y_axis_label='Amplitude * 1000', title=title, plot_height=plot_height,
                                           x_range=x_range, y_range=y_range, topic_instance=topic_instance)
         self._use_time_formatter = False
@@ -955,12 +955,11 @@ def add_graph(self, field_names, colors, legends):
                     step_size = int(len(fft_plot_values) / max_num_data_points)
                     fft_plot_values = fft_plot_values[::step_size]
                     freqs_plot = freqs_plot[::step_size]
-                self._p.line(freqs_plot, fft_plot_values,
-                             line_color=color, line_width=2, legend_label=legend,
-                             alpha=0.8)
+                self._p.line(freqs_plot, fft_plot_values, # pylint: disable=too-many-function-args
+                             line_color=color, line_width=2, legend_label=legend, alpha=0.8)
             # plot the mean lines above the fft graphs
             for fft_values, mean_fft_value, legend, color in plot_data:
-                self._p.line([mean_start_freq, np.max(freqs)],
+                self._p.line([mean_start_freq, np.max(freqs)], # pylint: disable=too-many-function-args
                              [mean_fft_value, mean_fft_value],
                              line_color=color, line_width=2, legend_label=legend)
 

app/plot_app/statistics_plots.py

@@ -543,7 +543,7 @@ def _plot_public_data_statistics(self, all_data, version_attr_name,
         x = data_hours['x']
         x2 = np.hstack((x[::-1], x))
         for i in range(len(all_data)):
-            area.patch(x2, stacked_patches[i], color=colors[i],
+            area.patch(x2, stacked_patches[i], color=colors[i], # pylint: disable=too-many-function-args
                        legend_label=label_cb(all_data[i], False), alpha=0.8, line_color=None)
 
         if area.legend:

app/plot_app/templates/browse.html

@@ -50,7 +50,6 @@ <h3>Browse public Log Files</h3>
 <script type="text/javascript">
 
 $(document).ready(function() {
-    console.log("test");
 	$('#logs_table').DataTable({
 {% if initial_search %}
         "search": {
@@ -85,7 +84,6 @@ <h3>Browse public Log Files</h3>
             "ajax": "browse_data_retrieval",
     });
     var table = $('#logs_table').DataTable();
-    console.log("table!",table);
     table.on('xhr', function () {
 
         try {
@@ -100,7 +98,6 @@ <h3>Browse public Log Files</h3>
             }
             window.history.replaceState(null, null, url);
         } catch (e) {
-            console.log("Failed")
         }
     });
 

app/tornado_handlers/browse.py

@@ -211,8 +211,8 @@ def get_columns_from_tuple(db_tuple, counter):
                 if columns is None:
                     continue
 
-                if any([search_str in str(column).lower() for column in \
-                        (columns.columns, columns.search_only_columns)]):
+                if any(search_str in str(column).lower() for column in \
+                        (columns.columns, columns.search_only_columns)):
                     if data_start <= filtered_counter < data_start + data_length:
                         json_output['data'].append(columns.columns)
                     filtered_counter += 1
@@ -244,7 +244,6 @@ def get(self, *args, **kwargs):
         template_args = {}
 
         search_str = self.get_argument('search', '').lower()
-        print("Browse!")
         if len(search_str) > 0:
             template_args['initial_search'] = json.dumps(search_str)
 

app/tornado_handlers/common.py

@@ -29,7 +29,7 @@ class CustomHTTPError(tornado.web.HTTPError):
     """ simple class for HTTP exceptions with a custom error message """
     def __init__(self, status_code, error_message=None):
         self.error_message = error_message
-        super(CustomHTTPError, self).__init__(status_code, error_message)
+        super().__init__(status_code, error_message)
 
 class TornadoRequestHandlerBase(tornado.web.RequestHandler):
     """

app/tornado_handlers/download.py

@@ -108,9 +108,9 @@ def kml_colors(flight_mode):
                                      style=style,
                                      camera_trigger_topic_name='camera_capture')
                     shutil.move(temp_file_name, kml_file_name)
-                except:
+                except Exception as e:
                     print('Error creating KML file', sys.exc_info()[0], sys.exc_info()[1])
-                    raise CustomHTTPError(400, 'No Position Data in log')
+                    raise CustomHTTPError(400, 'No Position Data in log') from e
 
 
             kml_dl_file_name = get_original_filename('track.kml', '.kml')

app/tornado_handlers/multipart_streamer.py

@@ -143,7 +143,7 @@ def __init__(self, streamer, headers, tmp_dir=None):
         the temporary file to a different location. If you do not call the
         move() method, then the file will be deleted when release() is called.
         """
-        super(TemporaryFileStreamedPart, self).__init__(streamer, headers)
+        super().__init__(streamer, headers)
         self.is_moved = False
         self.is_finalized = False
         self.f_out = tempfile.NamedTemporaryFile(dir=tmp_dir, delete=False)
@@ -161,7 +161,7 @@ def finalize(self):
             self.f_out.flush()
             self.is_finalized = True
         finally:
-            super(TemporaryFileStreamedPart, self).finalize()
+            super().finalize()
 
     def move(self, file_path):
         """Move the temporary file to a new location.
@@ -189,7 +189,7 @@ def release(self):
                 self.f_out.close()
                 os.unlink(self.f_out.name)
         finally:
-            super(TemporaryFileStreamedPart, self).release()
+            super().release()
 
     def get_payload(self):
         """Load part data from disk and return it.

app/tornado_handlers/three_d.py

@@ -46,7 +46,7 @@ def get(self, *args, **kwargs):
                 400,
                 'The log does not contain all required topics<br />'
                 '(vehicle_gps_position, vehicle_global_position, '
-                'vehicle_attitude)')
+                'vehicle_attitude)') from error
 
         # manual control setpoint is optional
         manual_control_setpoint = None

app/tornado_handlers/upload.py

@@ -302,14 +302,14 @@ def post(self, *args, **kwargs):
             except CustomHTTPError:
                 raise
 
-            except ULogException:
+            except ULogException as e:
                 raise CustomHTTPError(
                     400,
-                    'Failed to parse the file. It is most likely corrupt.')
-            except:
+                    'Failed to parse the file. It is most likely corrupt.') from e
+            except Exception as e:
                 print('Error when handling POST data', sys.exc_info()[0],
                       sys.exc_info()[1])
-                raise CustomHTTPError(500)
+                raise CustomHTTPError(500) from e
 
             finally:
                 self.multipart_streamer.release_parts()