Modernizing the build process

Author: Turnerj

.appveyor.yml

@@ -3,25 +3,11 @@ image: Visual Studio 2019
 skip_branch_with_pr: true
 
 build_script:
-  - ps: .\build.appveyor.ps1
-  
+  - ps: dotnet restore
+  - ps: dotnet build --no-restore -c Release
+  - ps: dotnet test --no-restore /p:SkipBuildVersioning=true
+  - ps: dotnet pack --no-build -c Release /p:PackageOutputPath=build-artifacts
+
 test: false
 artifacts:
-  - path: '.\build-artifacts\*'
-
-deploy:
-  - provider: NuGet
-    artifact: /.*nupkg/
-    api_key:
-      secure: QNfyCsBxCLb4iGmaRd2ep7yYY3RMJKw54B7p+ZcFDo5pb8KnWM0ULl4ml2u38s/w
-    on:
-      APPVEYOR_REPO_TAG: true
-  - provider: GitHub
-    artifact: /.*nupkg/
-    draft: true
-    release: $(APPVEYOR_REPO_TAG_NAME)
-    description: 'TODO'
-    auth_token:
-      secure: 8WGv8noklaCJAQEBpcs+VShk/Hql5zbyx0VPhMvzUw0RcG7rAd2KxKIh4gazXlBi
-    on:
-      APPVEYOR_REPO_TAG: true
+  - path: '**\build-artifacts\*'

.github/workflows/build.yml

@@ -2,7 +2,7 @@ name: Build
 
 on:
   push:
-    branches: [ master ]
+    branches: [ main ]
   pull_request: 
   release:
     types: [ published ]
@@ -19,47 +19,9 @@ env:
 
 jobs:
 
-  version:
-    name: Identify build version
-    runs-on: ubuntu-latest
-    outputs:
-      BuildVersion: ${{steps.configureBuildVersion.outputs.BUILD_VERSION}}
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v2
-    - name: Fetch all Git tags
-      run: git fetch --prune --unshallow --tags
-    - name: Configure build version
-      id: configureBuildVersion
-      run: |
-        $githubRunId = $env:GITHUB_RUN_ID;
-        $prNumber = $env:PR_NUMBER;
-        $gitSourceVersion = git describe --tags --abbrev=7 --always 2>$1;
-        $gitSourceVersionSplit = [regex]::split($gitSourceVersion, "-(?=\d+-\w+)");
-        $version = $(if($gitSourceVersionSplit.length -eq 1){"0.0.0"}else{$gitSourceVersionSplit[0]});
-        $commitsSinceTag = '0';
-        $commitHash = $gitSourceVersionSplit[0];
-        if ($gitSourceVersionSplit.length -eq 2) {
-            $gitMetadata = $gitSourceVersionSplit[1].split("-");
-            $commitsSinceTag = $gitMetadata[0];
-            $commitHash = $gitMetadata[1];
-        }
-        $buildMetadata = "$($commitHash)-$($githubRunId)";
-        $customSuffix = $(if($prNumber -ne ''){"-PR$($prNumber)"}elseif($commitsSinceTag -ne '0'){"-dev"});
-        echo "::set-output name=BUILD_VERSION::$($version)$($customSuffix)+$($buildMetadata)";
-      shell: pwsh
-      env:
-        PR_NUMBER: ${{github.event.number}}
-    - name: Print build version
-      run: echo ${{steps.configureBuildVersion.outputs.BUILD_VERSION}}
-
-
   build:
     name: Build ${{matrix.os}}
     runs-on: ${{matrix.os}}
-    needs: version
-    env:
-      BUILD_VERSION: ${{needs.version.outputs.BuildVersion}}
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]
@@ -81,11 +43,11 @@ jobs:
     - name: Install dependencies
       run: dotnet restore
     - name: Build
-      run: dotnet build -c Release --no-restore /p:Version=${{env.BUILD_VERSION}}
+      run: dotnet build --no-restore -c Release
     - name: Test with Coverage
-      run: dotnet test --logger trx --results-directory ${{env.BUILD_ARTIFACT_PATH}}/coverage --collect "XPlat Code Coverage" --settings CodeCoverage.runsettings
+      run: dotnet test --no-restore --logger trx --results-directory ${{env.BUILD_ARTIFACT_PATH}}/coverage --collect "XPlat Code Coverage" --settings CodeCoverage.runsettings /p:SkipBuildVersioning=true
     - name: Pack
-      run: dotnet pack -c Release --no-build /p:Version=${{env.BUILD_VERSION}} /p:PackageOutputPath=${{env.BUILD_ARTIFACT_PATH}}
+      run: dotnet pack --no-build -c Release /p:PackageOutputPath=${{env.BUILD_ARTIFACT_PATH}}
     - name: Publish artifacts
       uses: actions/upload-artifact@v2
       with:
@@ -115,14 +77,39 @@ jobs:
       with:
         name: coverage-report
         path: Cobertura.xml
-      
-  release:
-    name: Release
+
+  push-to-github-packages:
+    name: 'Push GitHub Packages'
+    needs: build
+    if: github.ref == 'refs/heads/main' || github.event_name == 'release'
+    environment:
+      name: 'GitHub Packages'
+      url: https://github.com/TurnerSoftware/InfinityCrawler/packages
+    permissions:
+      packages: write
     runs-on: ubuntu-latest
+    steps:
+      - name: 'Download build'
+        uses: actions/download-artifact@v2
+        with:
+          name: 'ubuntu-latest'
+      - name: 'Add NuGet source'
+        run: dotnet nuget add source https://nuget.pkg.github.com/TurnerSoftware/index.json --name GitHub --username Turnerj --password ${{secrets.GITHUB_TOKEN}} --store-password-in-clear-text
+      - name: 'Upload NuGet package'
+        run: dotnet nuget push *.nupkg --api-key ${{secrets.GH_PACKAGE_REGISTRY_API_KEY}} --source GitHub --skip-duplicate --no-symbols true
+
+  push-to-nuget:
+    name: 'Push NuGet Packages'
     needs: build
     if: github.event_name == 'release'
+    environment:
+      name: 'NuGet'
+      url: https://www.nuget.org/packages/InfinityCrawler
+    runs-on: ubuntu-latest
     steps:
-    - name: Download build
-      uses: actions/download-artifact@v2
-    - run: ls /ubuntu-latest
-    # TODO: Upload to NuGet & GitHub Packages
+      - name: 'Download build'
+        uses: actions/download-artifact@v2
+        with:
+          name: 'ubuntu-latest'
+      - name: 'Upload NuGet package and symbols'
+        run: dotnet nuget push *.nupkg --source https://api.nuget.org/v3/index.json --skip-duplicate --api-key ${{secrets.NUGET_API_KEY}}

InfinityCrawler.sln

@@ -1,17 +1,14 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 16
-VisualStudioVersion = 16.0.29001.49
+# Visual Studio Version 17
+VisualStudioVersion = 17.0.31808.319
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "global", "global", "{F0B4D082-200A-4DD3-9291-872B7F2A991E}"
 	ProjectSection(SolutionItems) = preProject
 		.appveyor.yml = .appveyor.yml
 		.codecov.yml = .codecov.yml
 		.editorconfig = .editorconfig
 		.gitignore = .gitignore
-		build.appveyor.ps1 = build.appveyor.ps1
-		build.ps1 = build.ps1
-		buildconfig.json = buildconfig.json
 		CodeCoverage.runsettings = CodeCoverage.runsettings
 		License.txt = License.txt
 		README.md = README.md

README.md

@@ -2,10 +2,10 @@
 
 ![Icon](images/icon.png)
 # Infinity Crawler
-A simple but powerful web crawler library in C#
+A simple but powerful web crawler library for .NET 
 
-[![AppVeyor](https://img.shields.io/appveyor/ci/Turnerj/infinitycrawler/master.svg)](https://ci.appveyor.com/project/Turnerj/infinitycrawler)
-[![Codecov](https://img.shields.io/codecov/c/github/turnersoftware/infinitycrawler/master.svg)](https://codecov.io/gh/TurnerSoftware/infinitycrawler)
+![Build](https://img.shields.io/github/workflow/status/TurnerSoftware/infinitycrawler/Build)
+[![Codecov](https://img.shields.io/codecov/c/github/turnersoftware/infinitycrawler/main.svg)](https://codecov.io/gh/TurnerSoftware/infinitycrawler)
 [![NuGet](https://img.shields.io/nuget/v/InfinityCrawler.svg)](https://www.nuget.org/packages/InfinityCrawler)
 </div>