Skip to content

Commit 1cf6365

Browse files
Fix clippy::ptr_as_ptr (#1472)
1 parent 7e766d1 commit 1cf6365

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.bazelrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ build --aspects=@rules_rust//rust:defs.bzl%rustfmt_aspect
4545
build --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect
4646

4747
# TODO(aaronmondal): Extend these flags until we can run with clippy::pedantic.
48-
build --@rules_rust//:clippy_flags=-Dwarnings,-Dclippy::uninlined_format_args,-Dclippy::manual_string_new,-Dclippy::manual_let_else,-Dclippy::single_match_else,-Dclippy::redundant_closure_for_method_calls,-Dclippy::semicolon_if_nothing_returned,-Dclippy::unreadable_literal,-Dclippy::range_plus_one,-Dclippy::inconsistent_struct_constructor,-Dclippy::match_wildcard_for_single_variants,-Dclippy::implicit_clone,-Dclippy::needless_pass_by_value,-Dclippy::explicit_deref_methods,-Dclippy::trivially_copy_pass_by_ref,-Dclippy::unnecessary_wraps,-Dclippy::cast_lossless,-Dclippy::map_unwrap_or,-Dclippy::ref_as_ptr,-Dclippy::inline_always,-Dclippy::redundant_else,-Dclippy::return_self_not_must_use,-Dclippy::match_same_arms,-Dclippy::explicit_iter_loop,-Dclippy::items_after_statements,-Dclippy::explicit_into_iter_loop,-Dclippy::stable_sort_primitive
48+
build --@rules_rust//:clippy_flags=-Dwarnings,-Dclippy::uninlined_format_args,-Dclippy::manual_string_new,-Dclippy::manual_let_else,-Dclippy::single_match_else,-Dclippy::redundant_closure_for_method_calls,-Dclippy::semicolon_if_nothing_returned,-Dclippy::unreadable_literal,-Dclippy::range_plus_one,-Dclippy::inconsistent_struct_constructor,-Dclippy::match_wildcard_for_single_variants,-Dclippy::implicit_clone,-Dclippy::needless_pass_by_value,-Dclippy::explicit_deref_methods,-Dclippy::trivially_copy_pass_by_ref,-Dclippy::unnecessary_wraps,-Dclippy::cast_lossless,-Dclippy::map_unwrap_or,-Dclippy::ref_as_ptr,-Dclippy::inline_always,-Dclippy::redundant_else,-Dclippy::return_self_not_must_use,-Dclippy::match_same_arms,-Dclippy::explicit_iter_loop,-Dclippy::items_after_statements,-Dclippy::explicit_into_iter_loop,-Dclippy::stable_sort_primitive,-Dclippy::ptr_as_ptr
4949
build --@rules_rust//:clippy.toml=//:clippy.toml
5050

5151
test --@rules_rust//:rustfmt.toml=//:.rustfmt.toml

nativelink-store/tests/ref_store_test.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@ async fn inner_store_test() -> Result<(), Error> {
164164
// Ensure the result of inner_store() points to exact same memory store.
165165
assert_eq!(
166166
from_ref::<dyn StoreDriver>(ref_store_outer.inner_store(Option::<DigestInfo>::None))
167-
as *const (),
168-
from_ref::<dyn StoreDriver>(memory_store.into_inner().as_ref()) as *const (),
167+
.cast::<()>(),
168+
from_ref::<dyn StoreDriver>(memory_store.into_inner().as_ref()).cast::<()>(),
169169
"Expected inner store to be memory store"
170170
);
171171
Ok(())

nativelink-util/src/origin_context.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ pub trait Symbol {
7575
}
7676

7777
fn as_ptr(&'static self) -> *const RawSymbol {
78-
from_ref::<Self>(self) as *const RawSymbol
78+
from_ref::<Self>(self).cast::<RawSymbol>()
7979
}
8080
}
8181

0 commit comments

Comments
 (0)