Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: when video ad is being played the require data is not being populated from native side the object coming blank #4405

Open
thesaifalitai opened this issue Feb 4, 2025 · 2 comments
Labels

Comments

@thesaifalitai
Copy link

Version

"react-native-video": "^6.8.2"

What platforms are you having the problem on?

Android

System Version

Android 14

On what device are you experiencing the issue?

Real device

Architecture

New architecture with interop layer

What happened?

A bug happened!
My ad url is
https://nightlife.net/viddles/androidvnode.xml?sz=640x480&iu=/124319096/external/single_ad_samples&ciu_szs=300x250&impl=s&gdfp_req=1&env=vp&output=vast&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ct%3Dskippablelinear&correlator=

When my player is running the ad from remote url which is VAST

i am not getting ad url when i click on ad as follow log i seen
{"data":{},"event":"CLICKED"}

also check this log below
{"data":{},"event":"AD_PROGRESS"}

here is below one where i am getting ad events.

onReceiveAdEvent={(ads) => {
console.log("object of Ads" + JSON.stringify(ads));
if (ads.event == "CONTENT_PAUSE_REQUESTED") {
this.setState({
isPlayingAd: true,
});
} else if (ads.event == "CONTENT_RESUME_REQUESTED") {
this.setState({
isPlayingAd: false,
});
}
}}

Reproduction Link

repository link

Reproduction

Step to reproduce this bug are: just us this video ad url and run this onReceiveAdEvent to check what events are coming and is it coming with populated data as mentioned in documentation

Copy link

github-actions bot commented Feb 4, 2025

Thank you for your issue report. Please note that the following information is missing or incomplete:

  • reproduction link

Please update your issue with this information to help us address it more effectively.

Note: issues without complete information have a lower priority

There is a newer version of the library available. You are using version "react, while the latest stable version is native. Please update to the latest version and check if the issue still exists.

Note: If the issue still exists, please update the issue report with the latest information.

@freeboub
Copy link
Collaborator

I don't really understand:

  • why you need the url on all ad events ? (as you already know it in source)
  • where did you see the ad url shall be sent in every event

In term of performance, I don't think a good thing to add the url in all events ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants