Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview broken at tanstack.com/virtual #174

Closed
kosovojs opened this issue Feb 4, 2024 · 6 comments · Fixed by #182
Closed

preview broken at tanstack.com/virtual #174

kosovojs opened this issue Feb 4, 2024 · 6 comments · Fixed by #182

Comments

@kosovojs
Copy link

kosovojs commented Feb 4, 2024

currently seeing this error at https://tanstack.com/virtual/latest

image

@fulopkovacs
Copy link
Contributor

I can confirm that I do see this error when I visit https://tanstack.com/virtual/latest/docs/framework/react/examples/simple, but there is no react/simple example in the virtual repo either (see https://github.com/TanStack/virtual/tree/main/examples/react).

Did you experience when you visited the same url? If yes, could you tell me how you got to that page? Is there a link in the docs somewhere?

@kosovojs
Copy link
Author

kosovojs commented Feb 5, 2024

Not sure if i understood you correctly, but...

Did you experience when you visited the same url?

Yes, i do see the error in both my provided link and your.

If yes, could you tell me how you got to that page?

If you meant "how you got to https://tanstack.com/virtual/latest page" - the link is available at main https://tanstack.com/ page on library card.

P.S. now noticed, that the same problem is at https://tanstack.com/ranger/latest

@fulopkovacs
Copy link
Contributor

Woah, this is an interesting one. I can't see the issue for any of these urls (I tested it on multiple devices and browsers):

image image

I simply assumed that by https://tanstack.com/virtual/latest meant the examples for virtual, like https://tanstack.com/virtual/latest/docs/framework/react/examples/simple. 😆

Could you check these links in an incognito tab? We had some 301 - Moved permanently in the code base before, and recently we've reorganized the docs. I don't remember these routes being affected, but we should check this just to be sure.

@kosovojs
Copy link
Author

kosovojs commented Feb 9, 2024

it doesn't work incognito mode. checked all major Windows browsers (firefox, chrome, edge), on both Win10 and Win11. also on android chrome, too.

acusti added a commit to acusti/tanstack.com that referenced this issue Feb 9, 2024
examples/react/simple doesn’t exist
examples/react/fixed does exist and seems like the equivalent to “simple”
@acusti
Copy link
Contributor

acusti commented Feb 9, 2024

@fulopkovacs see #182

@fulopkovacs
Copy link
Contributor

Ahh, thanks for the PR @acusti, now I know which preview we're talking about. 😅 I'll review the PR!

fulopkovacs pushed a commit that referenced this issue Feb 12, 2024
* Update stackblitz embed src from /simple → /fixed #174

examples/react/simple doesn’t exist
examples/react/fixed does exist and seems like the equivalent to “simple”

* Update ranger stackblitz embed src from /simple → /basic

same fix as be3b03d applied to the ranger library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants