Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] [Form] “Fix” the framework dropdown #139

Closed
juliendelort opened this issue Oct 18, 2023 · 3 comments
Closed

[Docs] [Form] “Fix” the framework dropdown #139

juliendelort opened this issue Oct 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@juliendelort
Copy link

The framework dropdown has no effect when viewing a “core” page. Since users land on the Overview page (which is a “core” page), the dropdown looks broken, and it looks like we don’t support Vue (users have to go to a “react” page first before switching to “Vue”).

The dropdown should work even when seeing a core page, it should at least refresh the navigation menu to replace the React pages with the Vue pages.

As a side note, since the Overview page shows some React code, it may make sense to create an Overview/React and an Overview/Vue page (like in the TanStack Query docs)

@crutchcorn
Copy link
Member

CC @tannerlinsley I agree this needs changing, we've gotten repeated reports about this

@crutchcorn crutchcorn added the bug Something isn't working label Oct 18, 2023
@crutchcorn
Copy link
Member

@fulopkovacs is fixing this in:

#133

@crutchcorn crutchcorn changed the title [Docs] “Fix” the framework dropdown [Docs] [Form] “Fix” the framework dropdown Jan 9, 2024
@crutchcorn crutchcorn transferred this issue from TanStack/form Jan 9, 2024
@crutchcorn
Copy link
Member

Closing, as this is fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants