chore(deps): update eslint plugins (#7984)

lachlancollins · web-flow · commit 8fe90104c6fc · 2024-08-30T18:04:08.000+10:00
* chore(deps): update eslint plugins

* Refactor shadow-dom example
diff --git a/examples/react/basic/package.json b/examples/react/basic/package.json
@@ -21,7 +21,6 @@
     "@types/react": "^18.2.79",
     "@types/react-dom": "^18.2.25",
     "@vitejs/plugin-react": "^4.3.1",
-    "eslint": "^8.57.0",
     "typescript": "5.3.3",
     "vite": "^5.3.5"
   }
diff --git a/examples/react/shadow-dom/.eslintrc.cjs b/examples/react/shadow-dom/.eslintrc.cjs
diff --git a/examples/react/shadow-dom/eslint.config.js b/examples/react/shadow-dom/eslint.config.js
@@ -0,0 +1,19 @@
+import { tanstackConfig } from '@tanstack/config/eslint'
+import pluginQuery from '@tanstack/eslint-plugin-query'
+import pluginReact from '@eslint-react/eslint-plugin'
+import pluginReactHooks from 'eslint-plugin-react-hooks'
+
+export default [
+  ...tanstackConfig,
+  ...pluginQuery.configs['flat/recommended'],
+  pluginReact.configs.recommended,
+  {
+    plugins: {
+      'react-hooks': pluginReactHooks,
+    },
+    rules: {
+      'react-hooks/exhaustive-deps': 'error',
+      'react-hooks/rules-of-hooks': 'error',
+    },
+  },
+]
diff --git a/examples/react/shadow-dom/package.json b/examples/react/shadow-dom/package.json
@@ -4,9 +4,9 @@
   "type": "module",
   "scripts": {
     "dev": "vite",
-    "build": "tsc && vite build",
-    "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
-    "preview": "vite preview"
+    "build": "vite build",
+    "preview": "vite preview",
+    "test:types": "tsc"
   },
   "dependencies": {
     "@tanstack/react-query": "^5.52.3",
@@ -17,12 +17,7 @@
   "devDependencies": {
     "@types/react": "npm:types-react@rc",
     "@types/react-dom": "npm:types-react-dom@rc",
-    "@typescript-eslint/eslint-plugin": "^7.17.0",
-    "@typescript-eslint/parser": "^7.17.0",
     "@vitejs/plugin-react": "^4.3.1",
-    "eslint": "^8.57.0",
-    "eslint-plugin-react-hooks": "^4.6.2",
-    "eslint-plugin-react-refresh": "^0.4.9",
     "typescript": "5.3.3",
     "vite": "^5.3.5"
   }
diff --git a/examples/react/shadow-dom/src/DogList.tsx b/examples/react/shadow-dom/src/DogList.tsx
@@ -2,7 +2,7 @@ import { useQuery } from '@tanstack/react-query'
 
 type DogsResp = {
   message: {
-    [dog: string]: string[]
+    [dog: string]: Array<string>
   }
 }
 
@@ -22,7 +22,7 @@ export const DogList = () => {
 
   if (status === 'error') return 'Error!'
 
-  const dogs = Object.keys(data?.message)
+  const dogs = Object.keys(data.message)
 
   return (
     <div>
diff --git a/examples/react/shadow-dom/tsconfig.json b/examples/react/shadow-dom/tsconfig.json
@@ -20,6 +20,5 @@
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true
   },
-  "include": ["src"],
-  "references": [{ "path": "./tsconfig.node.json" }]
+  "include": ["src", "eslint.config.js"]
 }
diff --git a/examples/react/shadow-dom/tsconfig.node.json b/examples/react/shadow-dom/tsconfig.node.json
diff --git a/examples/svelte/simple/tsconfig.json b/examples/svelte/simple/tsconfig.json
@@ -15,6 +15,11 @@
     "checkJs": true,
     "isolatedModules": true
   },
-  "include": ["src/**/*.d.ts", "src/**/*.ts", "src/**/*.js", "src/**/*.svelte"],
-  "references": [{ "path": "./tsconfig.node.json" }]
+  "include": [
+    "src/**/*.d.ts",
+    "src/**/*.ts",
+    "src/**/*.js",
+    "src/**/*.svelte",
+    "vite.config.ts"
+  ]
 }
diff --git a/examples/svelte/simple/tsconfig.node.json b/examples/svelte/simple/tsconfig.node.json
diff --git a/examples/vue/basic/tsconfig.json b/examples/vue/basic/tsconfig.json
@@ -1,15 +1,24 @@
 {
   "compilerOptions": {
-    "target": "esnext",
-    "module": "esnext",
-    "moduleResolution": "node",
-    "strict": true,
-    "jsx": "preserve",
-    "sourceMap": true,
+    "target": "ES2020",
+    "useDefineForClassFields": true,
+    "module": "ESNext",
+    "lib": ["ES2020", "DOM", "DOM.Iterable"],
+    "skipLibCheck": true,
+
+    /* Bundler mode */
+    "moduleResolution": "Bundler",
+    "allowImportingTsExtensions": true,
     "resolveJsonModule": true,
-    "esModuleInterop": true,
-    "lib": ["esnext", "dom"],
-    "types": ["vite/client"]
+    "isolatedModules": true,
+    "noEmit": true,
+    "jsx": "preserve",
+
+    /* Linting */
+    "strict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noFallthroughCasesInSwitch": true
   },
   "include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.vue"]
 }
diff --git a/examples/vue/persister/tsconfig.json b/examples/vue/persister/tsconfig.json
@@ -1,15 +1,24 @@
 {
   "compilerOptions": {
-    "target": "esnext",
-    "module": "esnext",
-    "moduleResolution": "node",
-    "strict": true,
-    "jsx": "preserve",
-    "sourceMap": true,
+    "target": "ES2020",
+    "useDefineForClassFields": true,
+    "module": "ESNext",
+    "lib": ["ES2020", "DOM", "DOM.Iterable"],
+    "skipLibCheck": true,
+
+    /* Bundler mode */
+    "moduleResolution": "Bundler",
+    "allowImportingTsExtensions": true,
     "resolveJsonModule": true,
-    "esModuleInterop": true,
-    "lib": ["esnext", "dom"],
-    "types": ["vite/client"]
+    "isolatedModules": true,
+    "noEmit": true,
+    "jsx": "preserve",
+
+    /* Linting */
+    "strict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noFallthroughCasesInSwitch": true
   },
-  "include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.tsx", "src/**/*.vue"]
+  "include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.vue"]
 }
diff --git a/integrations/vue-vite/tsconfig.json b/integrations/vue-vite/tsconfig.json
@@ -20,6 +20,5 @@
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true
   },
-  "include": ["src/**/*.ts", "src/**/*.tsx", "src/**/*.vue", "vite.config.ts"],
-  "references": [{ "path": "./tsconfig.node.json" }]
+  "include": ["src/**/*.ts", "src/**/*.vue", "vite.config.ts"]
 }
diff --git a/integrations/vue-vite/tsconfig.node.json b/integrations/vue-vite/tsconfig.node.json
diff --git a/package.json b/package.json
@@ -38,8 +38,8 @@
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.15.3",
-    "@cspell/eslint-plugin": "^8.12.1",
-    "@eslint-react/eslint-plugin": "^1.6.0",
+    "@cspell/eslint-plugin": "^8.14.2",
+    "@eslint-react/eslint-plugin": "^1.12.3",
     "@solidjs/testing-library": "^0.8.9",
     "@tanstack/config": "^0.11.1",
     "@testing-library/jest-dom": "^6.4.8",
@@ -49,11 +49,11 @@
     "@types/react": "npm:types-react@rc",
     "@types/react-dom": "npm:types-react-dom@rc",
     "@vitest/coverage-istanbul": "^2.0.4",
-    "@vitest/eslint-plugin": "^1.0.2",
+    "@vitest/eslint-plugin": "^1.1.0",
     "cpy-cli": "^5.0.0",
     "esbuild-plugin-file-path-extensions": "^2.1.2",
     "eslint": "^8.57.0",
-    "eslint-plugin-react-hooks": "^4.6.2",
+    "eslint-plugin-react-hooks": "^5.1.0-rc-a19a8ab4-20240829",
     "jsdom": "^25.0.0",
     "knip": "^5.27.0",
     "nx": "^19.5.3",
diff --git a/packages/react-query/package.json b/packages/react-query/package.json
@@ -65,7 +65,7 @@
     "@types/react": "npm:types-react@rc",
     "@types/react-dom": "npm:types-react-dom@rc",
     "@vitejs/plugin-react": "^4.3.1",
-    "eslint-plugin-react-compiler": "0.0.0-experimental-c8b3f72-20240517",
+    "eslint-plugin-react-compiler": "0.0.0-experimental-f8a5409-20240829",
     "react": "19.0.0-rc-4c2e457c7c-20240522",
     "react-dom": "19.0.0-rc-4c2e457c7c-20240522",
     "react-error-boundary": "^4.0.13"
diff --git a/packages/react-query/src/HydrationBoundary.tsx b/packages/react-query/src/HydrationBoundary.tsx
@@ -1,3 +1,5 @@
+/* eslint-disable react-compiler/react-compiler */
+
 'use client'
 import * as React from 'react'
 
diff --git a/packages/react-query/src/useMutationState.ts b/packages/react-query/src/useMutationState.ts
@@ -1,3 +1,5 @@
+/* eslint-disable react-compiler/react-compiler */
+
 'use client'
 import * as React from 'react'
 
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@`
`21`	`21`	`"@types/react": "^18.2.79",`
`22`	`22`	`"@types/react-dom": "^18.2.25",`
`23`	`23`	`"@vitejs/plugin-react": "^4.3.1",`
`24`		`- "eslint": "^8.57.0",`
`25`	`24`	`"typescript": "5.3.3",`
`26`	`25`	`"vite": "^5.3.5"`
`27`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import { useQuery } from '@tanstack/react-query'`
`2`	`2`
`3`	`3`	`type DogsResp = {`
`4`	`4`	`message: {`
`5`		`- [dog: string]: string[]`
	`5`	`+ [dog: string]: Array<string>`
`6`	`6`	`}`
`7`	`7`	`}`
`8`	`8`
`@@ -22,7 +22,7 @@ export const DogList = () => {`
`22`	`22`
`23`	`23`	`if (status === 'error') return 'Error!'`
`24`	`24`
`25`		`- const dogs = Object.keys(data?.message)`
	`25`	`+ const dogs = Object.keys(data.message)`
`26`	`26`
`27`	`27`	`return (`
`28`	`28`	`<div>`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,5 @@`
`20`	`20`	`"noUnusedParameters": true,`
`21`	`21`	`"noFallthroughCasesInSwitch": true`
`22`	`22`	`},`
`23`		`- "include": ["src"],`
`24`		`- "references": [{ "path": "./tsconfig.node.json" }]`
	`23`	`+ "include": ["src", "eslint.config.js"]`
`25`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+/* eslint-disable react-compiler/react-compiler */`
	`2`	`+`
`1`	`3`	`'use client'`
`2`	`4`	`import * as React from 'react'`
`3`	`5`