Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move viewers to a dedicated view subpackage #33

Open
wavexx opened this issue Dec 21, 2020 · 1 comment
Open

Move viewers to a dedicated view subpackage #33

wavexx opened this issue Dec 21, 2020 · 1 comment

Comments

@wavexx
Copy link
Member

wavexx commented Dec 21, 2020

This is needed in order to delay the intiialization of Qt/matplotlib until the actual "view" function is needed and/or to allow usage of the io data/models without Qt itself.
wavexx added a commit that referenced this issue Dec 21, 2020
@wavexx
Use entry_points to install the gtabview executable
ba23fa1 
Supersedes #23, fixes #20 and hopefully unblocks #24.

Move gtabview into a dedicated gtabview_cli package in order to
ensure the gtabview module is loaded on demand as previously done.

This is still not ideal. The graphical initialization of gtabview should
probably be moved to a submodule of gtabview itself (such as
gtabview.view) so that models can be used/tested without QT to begin
with (see #33)
@wavexx wavexx mentioned this issue Dec 21, 2020
Closed
@wavexx
Copy link
Member Author

wavexx commented Dec 30, 2020

When doing this, remember to merge back gtabview_cli module into gtabview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wavexx