Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rutorrent: upgrade 4.3.7 => 5.1.5 #6404

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

smaarn
Copy link
Contributor

@smaarn smaarn commented Jan 18, 2025

Description

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested

Type of change

  • Package update

Status

  • Fix dump plugin (add dumptorrent)
  • Fix ratio plugin loading
  • Update default logs (currently echoed into /tmp/errors.log)

* Bump PHP requirement to 8.2
@smaarn smaarn changed the title upgrade rutorrent 4.3.7 => 5.1.5 rutorrent: upgrade 4.3.7 => 5.1.5 Jan 18, 2025
@hgy59
Copy link
Contributor

hgy59 commented Jan 18, 2025

@smaarn I already have a local update to rutorrent 4.3.9 including updates for

  • cross/libtorrent-rakshasa from v0.13.8 with git hash 71a487c66b136524bce5519cb1f9e855621a9101 to official v0.14.0 (no hash required)
  • cross/rtorrent from v0.9.8 with git hash eacf9798e2787df7dd4d5c800a46bac7931ac41c to official v 0.10.0 (no hash required)
  • cross/xmlrpc-c from v1.51.06 to v1.59.03

and work on spk/rutorrent in progress to:

  • migrate to redesiged shared folders with SERVICE_WIZARD_SHARENAME
  • remove DSM 6 specific code in service-setup.sh

If you don't mind I could add the updated dependencies soon and help with the spk definitions later...

@smaarn
Copy link
Contributor Author

smaarn commented Jan 18, 2025

@smaarn I already have a local update to rutorrent 4.3.9 including updates for

  • cross/libtorrent-rakshasa from v0.13.8 with git hash 71a487c66b136524bce5519cb1f9e855621a9101 to official v0.14.0 (no hash required)
  • cross/rtorrent from v0.9.8 with git hash eacf9798e2787df7dd4d5c800a46bac7931ac41c to official v 0.10.0 (no hash required)
  • cross/xmlrpc-c from v1.51.06 to v1.59.03

and work on spk/rutorrent in progress to:

  • migrate to redesiged shared folders with SERVICE_WIZARD_SHARENAME
  • remove DSM 6 specific code in service-setup.sh

If you don't mind I could add the updated dependencies soon and help with the spk definitions later...

@hgy59 by all means, do ! This PR was just to kick off the upgrade work in a "minimal" effort mode (e.g. have the build passing, play with things to see if there needs to be more advanced config changes...).

hgy59 added 4 commits January 18, 2025 22:26
- update cross/libtorrent-rakshasa from v0.13.8 to v0.14.0 (drop specific commit by hash)
- update cross/rtorrent from v0.9.8 to v0.10.0 (drop specific commit by hash)
- update cross/xmlrpc-c from v1.51.06 to v1.59.03
- spk/rutorrent:
  - drop rutorrent.sc (same as default, generated by spksrc.spk.mk)
  - adjust changelog
- add cross/screen5 (requires DSM 7, i.e. std c17)
@hgy59
Copy link
Contributor

hgy59 commented Jan 19, 2025

@smaarn dependencies updated (and master merged into this)

Thanks to #6255 the github prepare action takes now less than one minute including the source download.

For spk/rutorrent files, further investigation is required.

@mreid-tt shall we try to update this package for DSM 7.1 with PHP 8.0 and DSM 7.2 with PHP 8.2?

@mreid-tt
Copy link
Contributor

@mreid-tt shall we try to update this package for DSM 7.1 with PHP 8.0 and DSM 7.2 with PHP 8.2?

@hgy59, we can try both yes. I am a bit unsure why we are bumping the PHP version however since the release notes for ruTorrent don't seem to make any special mention of a minimum PHP 8 requirement.

If this is in fact needed then a build for different versions of PHP will show errors when run with incompatible versions (similar to #6229).

@smaarn
Copy link
Contributor Author

smaarn commented Jan 19, 2025

@mreid-tt shall we try to update this package for DSM 7.1 with PHP 8.0 and DSM 7.2 with PHP 8.2?

@hgy59, we can try both yes. I am a bit unsure why we are bumping the PHP version however since the release notes for ruTorrent don't seem to make any special mention of a minimum PHP 8 requirement.

If this is in fact needed then a build for different versions of PHP will show errors when run with incompatible versions (similar to #6229).

@mreid-tt actually I was under the impression that I couldn't install PHP 7.4 on my DSM (7.2). Turns out I was wrong. We can definitely avoid upgrading then. I'm not sure, though, about a "build" for different versions of PHP causing incompatibilities (it's only runtime dependencies from what I recall), right ?

I will revert the PHP upgrade anyway since it would minimize the "risk" of this upgrade.

@hgy59 hgy59 mentioned this pull request Jan 26, 2025
6 tasks
@smaarn
Copy link
Contributor Author

smaarn commented Feb 1, 2025

Status: installation successful but get the following warnings at startup:

[01.02.2025 21:35:26] WebUI started.
[01.02.2025 21:35:27] ratio: Le plugin ne peut pas démarrer pour une raison inconnue.
[01.02.2025 21:35:27] dump: Le plugin ne fonctionnera pas. rTorrent ne peut pas accéder au(x) programme(s) externe(s). (dumptorrent).

Fix installation directory for dumptorrent and scrapec
@smaarn
Copy link
Contributor Author

smaarn commented Feb 5, 2025

Summary of situation:

  • dump plugin fixed
  • ratio plugin cannot work against latest version of rtorrent (get a lot of "command not supported" errors in the logs)

@hgy59 do you recall what were the reasoning behind the version upgrades and why you picked those specific versions (and not others) ?

@hgy59
Copy link
Contributor

hgy59 commented Feb 5, 2025

@hgy59 do you recall what were the reasoning behind the version upgrades and why you picked those specific versions (and not others) ?

cross/libtorrent-rakshasa

  • take latest release

cross/rtorrent

  • take latest release

cross/xmlrpc-c

  • take latest release (but update to v1.60.04 is available now)

what else?

@smaarn
Copy link
Contributor Author

smaarn commented Feb 5, 2025

@hgy59 do you recall what were the reasoning behind the version upgrades and why you picked those specific versions (and not others) ?

cross/libtorrent-rakshasa

  • take latest release

cross/rtorrent

  • take latest release

cross/xmlrpc-c

  • take latest release (but update to v1.60.04 is available now)

what else?

Will be having a crack at reverting the upgrade of libtorrent and rtorrent to the "unstable" version and see how it goes. It turns out that 0.9.8 is the latest "stable" version and the recommended one for rutorrent so we may not even have a choice, but let's try with the 0.10.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request] ruTorrent 5.1
3 participants