-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rutorrent: upgrade 4.3.7 => 5.1.5 #6404
base: master
Are you sure you want to change the base?
Conversation
* Bump PHP requirement to 8.2
@smaarn I already have a local update to rutorrent 4.3.9 including updates for
and work on spk/rutorrent in progress to:
If you don't mind I could add the updated dependencies soon and help with the spk definitions later... |
@hgy59 by all means, do ! This PR was just to kick off the upgrade work in a "minimal" effort mode (e.g. have the build passing, play with things to see if there needs to be more advanced config changes...). |
- update cross/libtorrent-rakshasa from v0.13.8 to v0.14.0 (drop specific commit by hash) - update cross/rtorrent from v0.9.8 to v0.10.0 (drop specific commit by hash) - update cross/xmlrpc-c from v1.51.06 to v1.59.03 - spk/rutorrent: - drop rutorrent.sc (same as default, generated by spksrc.spk.mk) - adjust changelog
- add cross/screen5 (requires DSM 7, i.e. std c17)
… rutorrent/upgrade-5.1
@smaarn dependencies updated (and master merged into this) Thanks to #6255 the github prepare action takes now less than one minute including the source download. For spk/rutorrent files, further investigation is required. @mreid-tt shall we try to update this package for DSM 7.1 with PHP 8.0 and DSM 7.2 with PHP 8.2? |
@hgy59, we can try both yes. I am a bit unsure why we are bumping the PHP version however since the release notes for ruTorrent don't seem to make any special mention of a minimum PHP 8 requirement. If this is in fact needed then a build for different versions of PHP will show errors when run with incompatible versions (similar to #6229). |
@mreid-tt actually I was under the impression that I couldn't install PHP 7.4 on my DSM (7.2). Turns out I was wrong. We can definitely avoid upgrading then. I'm not sure, though, about a "build" for different versions of PHP causing incompatibilities (it's only runtime dependencies from what I recall), right ? I will revert the PHP upgrade anyway since it would minimize the "risk" of this upgrade. |
Status: installation successful but get the following warnings at startup:
|
Fix installation directory for dumptorrent and scrapec
Fix configuration of dump plugin
PR Review: simplify installation of dumptorrent and scrapec binaries
Fix PLIST
This reverts commit 80a7014.
Summary of situation:
@hgy59 do you recall what were the reasoning behind the version upgrades and why you picked those specific versions (and not others) ? |
cross/libtorrent-rakshasa
cross/rtorrent
cross/xmlrpc-c
what else? |
This reverts commit 9b347c4.
Will be having a crack at reverting the upgrade of libtorrent and rtorrent to the "unstable" version and see how it goes. It turns out that 0.9.8 is the latest "stable" version and the recommended one for rutorrent so we may not even have a choice, but let's try with the 0.10.0 version. |
Description
Checklist
all-supported
completed successfullyType of change
Status
dump
plugin (adddumptorrent
)ratio
plugin loading/tmp/errors.log
)