Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling approach is problematic #42

Open
oliversalzburg opened this issue Jun 22, 2016 · 1 comment
Open

Bundling approach is problematic #42

oliversalzburg opened this issue Jun 22, 2016 · 1 comment

Comments

@oliversalzburg
Copy link
Member

The README suggests that the npm pack approach is almost a great feature, but I disagree.

npm pack, or anything that uses fstream-npm is bad to rely on when dealing with a NodeJS project. Not only does it rely on .npmignore, a file we already have a different purpose for, it also ignores tons of files we might want to keep (our main issue are private modules). In fact, the ignore semantics are incredibly complicated.

This means that the bundles created from strider-ssh-deploy are not usable application snapshots. The result of which is that we have to manually create packages, put them into HTTP-accessible storage and download them on the production server all via custom scripts.

I would propose that a simply tar czf package.tgz * is used in place of npmd-pack.

@knownasilya
Copy link
Member

I don't personally use this plugin, but I can see how that would be problematic. There might even be solutions that have an alternate ignore file that do compressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants