Merge branch 'mrdoob:dev' into dev

Spiri0 · web-flow · commit 93d64f0fbcf6 · 2025-02-08T08:19:34.000+01:00
diff --git a/examples/jsm/interactive/SelectionHelper.js b/examples/jsm/interactive/SelectionHelper.js
@@ -59,6 +59,8 @@ class SelectionHelper {
 		this.renderer.domElement.removeEventListener( 'pointermove', this.onPointerMove );
 		this.renderer.domElement.removeEventListener( 'pointerup', this.onPointerUp );
 
+		this.element.remove(); // in case disposal happens while dragging
+
 	}
 
 	onSelectStart( event ) {
@@ -95,7 +97,7 @@ class SelectionHelper {
 
 	onSelectOver() {
 
-		this.element.parentElement.removeChild( this.element );
+		this.element.remove();
 
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,8 @@ class SelectionHelper {`
`59`	`59`	`this.renderer.domElement.removeEventListener( 'pointermove', this.onPointerMove );`
`60`	`60`	`this.renderer.domElement.removeEventListener( 'pointerup', this.onPointerUp );`
`61`	`61`
	`62`	`+ this.element.remove(); // in case disposal happens while dragging`
	`63`	`+`
`62`	`64`	`}`
`63`	`65`
`64`	`66`	`onSelectStart( event ) {`
`@@ -95,7 +97,7 @@ class SelectionHelper {`
`95`	`97`
`96`	`98`	`onSelectOver() {`
`97`	`99`
`98`		`- this.element.parentElement.removeChild( this.element );`
	`100`	`+ this.element.remove();`
`99`	`101`
`100`	`102`	`}`
`101`	`103`