Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most examples are uncategorized in Examples panel #18

Open
1ec5 opened this issue Jul 9, 2020 · 1 comment
Open

Most examples are uncategorized in Examples panel #18

1ec5 opened this issue Jul 9, 2020 · 1 comment

Comments

@1ec5
Copy link
Member

1ec5 commented Jul 9, 2020

The panel that appears when pressing the Examples button shows most of the examples as being uncategorized, despite them being categorized on the wiki page that it gets the examples from. Specifically, every category’s first example shows up under the category, but each of the category’s subsequent examples show up in the unlabeled category.

@1ec5
Copy link
Member Author

1ec5 commented Jul 9, 2020

This issue appears to have been caused by MediaWiki (justifiably) wrapping each section in a <section> tag in Parsoid 1.6.0.

This became a nonissue upstream when Parsoid was replaced by the PHP parser in wikimedia/wikidata-query-gui@45149ba. The specific fix was to make wikibase.queryService.api.QuerySamples._findPrev() recursive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant