[NO JIRA]: Clean up and remove cycle dependency (#56)

* [NO JIRA]: Clean up and remove cycle dependency

* [NO JIRA]: Modify changelog

---------

Co-authored-by: Aleksandr Sannikov <[email protected]>

Author: xalechez

.gitignore

@@ -1,3 +1,4 @@
 /node_modules
 npm-debug.log
 *.css
+.idea

CHANGELOG.md

@@ -3,8 +3,11 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
-
 ## Unreleased
+- Remove dependency of backpack to break cycle dependency
+- Remove usage of sassFunctions as this is no longer needed after release of Backpack v31
+
+## 1.0.0
 
 ## 1.0.0
 

index.js

@@ -28,8 +28,6 @@ const sass = require('node-sass');
 const ora = require('ora');
 const { argv } = require('yargs');
 
-const functions = require('@skyscanner/backpack-web/bpk-mixins/sass-functions');
-
 const importer = require('./importer');
 
 const getSassFiles = () =>
@@ -124,7 +122,6 @@ const worker = () =>
             {
               file,
               importer,
-              functions,
               outputStyle: 'compressed',
             },
             (error, result) => {

package-lock.json

@@ -45,7 +45,6 @@
     "prettier": "prettier --config .prettierrc --write \"**/*.{js,jsx}\""
   },
   "dependencies": {
-    "@skyscanner/backpack-web": "^29.6.0",
     "chokidar": "^3.5.3",
     "fast-glob": "^3.3.1",
     "find-parent-dir": "^0.3.1",

package.json

@@ -16,8 +16,6 @@
  * limitations under the License.
  */
 
-@import '~@skyscanner/backpack-web/bpk-mixins/index';
-
 .button {
   @include bpk-unknown;
 }

test/fail/test.scss

@@ -16,12 +16,8 @@
  * limitations under the License.
  */
 
-@import '~@skyscanner/backpack-web/bpk-mixins/index';
+@import '~test';
 
 .button {
   @include bpk-button;
 }
-
-.icon {
-  @include bpk-icon(flight, $bpk-color-sky-blue);
-}

test/pass/_test.scss

@@ -16,12 +16,8 @@
  * limitations under the License.
  */
 
-@import '~@skyscanner/backpack-web/bpk-mixins/index';
+@import '~test';
 
 .button {
   @include bpk-button;
 }
-
-.icon {
-  @include bpk-icon(flight, $bpk-color-sky-blue);
-}

test/pass/node_modules/test.scss

@@ -26,8 +26,6 @@ const sass = require('node-sass');
 const ora = require('ora');
 const { argv } = require('yargs');
 
-const functions = require('@skyscanner/backpack-web/bpk-mixins/sass-functions');
-
 const importer = require('./importer');
 
 const getCssFileName = (name) => name.replace(/\.scss/, '.css');
@@ -43,15 +41,14 @@ const compileSass = async (file, spinner) => {
     const result = await renderSass({
       file,
       importer,
-      functions,
       outputStyle: 'compressed',
     });
 
     let prefixedContents;
 
     if (argv.prefixComment) {
       try {
-        const comment = `/* 
+        const comment = `/*
 ${argv.prefixComment.replace(/^/gm, ' * ')}
 */`;
         prefixedContents = [comment, result.css].join('\n');