Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn-lock-changes gets confused when a PR is on an older commit than default branch #33

Open
tido64 opened this issue Jul 26, 2021 · 1 comment
Labels
Issue Something isn't working

Comments

@tido64
Copy link

tido64 commented Jul 26, 2021

When the default branch has a yarn.lock with more recent packages than the branch that a PR is based on, yarn-lock-changes thinks that the PR is downgrading said packages even though it doesn't actually change yarn.lock. Example:

  • @babel/core is at 7.14.8 on default branch
  • PR is based on a commit that is just before the bump of @babel/core
  • yarn-lock-changes thinks that the PR is downgrading @babel/core

See microsoft/react-native-test-app#426.

@Simek
Copy link
Owner

Simek commented Jul 26, 2021

@tido64 Thank you for the report! This is something weird, I'm not even sure what have triggered the lock check which results in base yarn.lock related comment in PR where only examples/yarn.lock has been changed. Maybe auto-merge event is related to this behaviour somehow, I'm not familiar with this operation, but will look on the details later.

As a temporary solution I would recommend to setup dorny/paths-filter@v2 action which allows to run certain step in the workflow only when given file has been changed. Hope that fix the issue for you.

@Simek Simek added the Issue Something isn't working label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants