-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ancestors to determine test framework in code lens #1334
Comments
That would be great. |
This issue is being marked as stale because there was no activity in the last 2 months |
As a note, when we implement this, we should look for That would let us support users who want to support the declarative syntax of AS::TC, who don't wish to use the whole thing. |
+1 This would be a great feature! |
+1 - I use rspec-mocks in a project, but use Minitest as the test runner and Ruby LSP is detecting the test framework as rspec because it's only checking for the string Can an option be added to explicitly override the test framework? |
I would rather just implement the correct solution straight away. I'd avoid adding more configuration for something we can properly detect automatically. Also, there are other corner cases that wouldn't be covered, like someone who reported using both RSpec and Minitest in the same application. |
While I understand not wanting to add an additional configuration option, doing so solves many of the use-cases quickly and the |
Depends on #1333(complete)We currently try to determine the test framework based on dependencies. This is an okay approach, but once we have ancestors available we can be a lot more accurate.
We can check if a test inherits from
Minitest::Test
orTest::Unit::TestCase
and then decide based on that - ideally with a fallback if we can't determine the framework for whatever reason.The text was updated successfully, but these errors were encountered: