Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shopify theme push -x documentation (it uploads, doesn't download) #5316

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Update shopify theme push -x documentation (it uploads, doesn't download) #5316

merged 1 commit into from
Jan 31, 2025

Conversation

karreiro
Copy link
Contributor

WHY are these changes introduced?

Fixes #5315

WHAT is this pull request doing?

Updates shopify theme push -x docs.

How to test your changes?

shopify theme push -h

Post-release steps

N/A

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@karreiro karreiro requested review from a team as code owners January 30, 2025 09:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 75.48% 8996/11919
🟡 Branches 70.66% 4388/6210
🟡 Functions 75.29% 2362/3137
🟡 Lines
75.99% (+0.01% 🔼)
 8498/11183
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
95.18% (-1.2% 🔻)
86.49% (-2.7% 🔻)
 95.45% 100%

Test suite run success

2032 tests passing in 909 suites.

Report generated by 🧪jest coverage report action from 88ba848

frandiox
frandiox approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@karreiro karreiro added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 07623f2 Jan 31, 2025
27 checks passed
@karreiro karreiro deleted the fix-push-docs branch January 31, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graygilmore graygilmore graygilmore approved these changes

@frandiox frandiox frandiox approved these changes

@EvilGenius13 EvilGenius13 EvilGenius13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: shopify theme push -x documentation is not accurate
4 participants
@karreiro @graygilmore @frandiox @EvilGenius13