Improve mechanism that adds .shopify to .gitignore to avoid duplicate entries
#5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success2034 tests passing in 909 suites. Report generated by 🧪jest coverage report action from da606a6 |
isaacroldan
approved these changes
Jan 30, 2025
graygilmore
approved these changes
Jan 30, 2025
| const ignoreManager = ignore.default({allowRelativePaths: true}).add(lines) | ||
|
|
||
| const isIgnoredEntry = ignoreManager.ignores(joinPath(entry)) | ||
| const isIgnoredEntryAsDir = ignoreManager.ignores(joinPath(entry, 'ignored.txt')) |
There was a problem hiding this comment.
It's a mocked file entry that supports the following two test scenarios:
- does nothing when .shopify/* pattern exists in .gitignore
- does nothing when .shopify/** pattern exists in .gitignore
The ignore package doesn't interact with the file system; it just analyzes paths and patterns. This mocked entry helps us ensure that .shopify/* and .shopify/** are really working as expected.
karreiro
force-pushed
the
gitignore-bug
branch
from
c865c3f to
8eb0b1e
Compare
karreiro
force-pushed
the
gitignore-bug
branch
from
8eb0b1e to
da606a6
Compare
|
(I rebased the branch and fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #5286
WHAT is this pull request doing?
Instead of manipulating raw strings, now
addToGitIgnoreuses theignoremodule (already being used by apps), so we may prevent equivalent patterns from being added.It's important to notice though, that not all patterns reported on Fixes #5286 are equivalent as we may notice in the screenshot below:
How to test your changes?
shopify theme metafields pull.shopify/metafields.json.shopifyentry from.gitignore.shopify/metafields.jsonfile is created, an entry is also added in the.gitignorePost-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist