Skip to content

Commit 660c8c9

Browse files
authored
fix(): prefix with _ (#14)
* fix(): prefix with _
1 parent 43d4f8b commit 660c8c9

16 files changed

+59
-62
lines changed

.github/ISSUE_TEMPLATE/bug_report.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ body:
1515
- label: I agree to follow this project's Code of Conduct
1616
required: true
1717
- type: dropdown
18-
id: $branches
18+
id: _branches
1919
attributes:
2020
label: Repository Branches
2121
description: Fetched by action
@@ -27,7 +27,7 @@ body:
2727
validations:
2828
required: true
2929
- type: dropdown
30-
id: $labels
30+
id: _labels
3131
attributes:
3232
label: Repository labels
3333
description: Fetched by action
@@ -46,7 +46,7 @@ body:
4646
validations:
4747
required: true
4848
- type: dropdown
49-
id: $dates
49+
id: _dates
5050
attributes:
5151
label: Updating Dates
5252
description: Choose a day next week

.github/ISSUE_TEMPLATE/long_report.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -1063,18 +1063,18 @@ body:
10631063
validations:
10641064
required: true
10651065
- type: dropdown
1066-
id: $subs
1066+
id: _subs
10671067
attributes:
10681068
label: Recursive
10691069
description: >-
10701070
Uses [Dynamic
10711071
Substitution](https://github.com/ShaMan123/gha-form-dropdown-options#dynamic-substitution)
10721072
options:
1073-
- 2022-09-27T00:00:00.000Z
1074-
- 2022-09-28T00:00:00.000Z
1075-
- 2022-09-29T00:00:00.000Z
1076-
- 2022-09-30T00:00:00.000Z
1077-
- 2022-10-01T00:00:00.000Z
1073+
- 2022-09-27 00:00
1074+
- 2022-09-28 08:00
1075+
- 2022-09-29 12:00
1076+
- 2022-09-30 16:00
1077+
- 2022-10-01 20:00
10781078
validations:
10791079
required: true
10801080
- type: textarea

.github/template_report.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ body:
5353
validations:
5454
required: true
5555
- type: dropdown
56-
id: $subs
56+
id: _subs
5757
attributes:
5858
label: Recursive
5959
description: 'Uses [Dynamic Substitution](https://github.com/ShaMan123/gha-form-dropdown-options#dynamic-substitution)'

.github/workflows/update_bug_report.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ jobs:
147147
uses: ./
148148
with:
149149
form: .github/ISSUE_TEMPLATE/bug_report.yml
150-
dropdown: $branches
150+
dropdown: _branches
151151
options: ${{ needs.pre.outputs.branches }}
152152
dry_run: no-push
153153
- name: Bug report modified? ${{ steps.branches.outputs.modified }}
@@ -158,7 +158,7 @@ jobs:
158158
uses: ./
159159
with:
160160
form: .github/ISSUE_TEMPLATE/bug_report.yml
161-
dropdown: $labels
161+
dropdown: _labels
162162
options: ${{ needs.pre.outputs.labels }}
163163
dry_run: no-push
164164
- name: Bug report modified? ${{ steps.labels.outputs.modified }}
@@ -169,7 +169,7 @@ jobs:
169169
uses: ./
170170
with:
171171
form: .github/ISSUE_TEMPLATE/bug_report.yml
172-
dropdown: $dates
172+
dropdown: _dates
173173
options: ${{ needs.pre.outputs.dates }}
174174
dry_run: no-push
175175
- name: Pushed? ${{ steps.branches.outputs.modified || steps.labels.outputs.modified || steps.dates.outputs.modified }}
@@ -218,7 +218,7 @@ jobs:
218218
# passing template again for testing
219219
template: .github/template_report.yml
220220
form: .github/ISSUE_TEMPLATE/long_report.yml
221-
dropdown: $subs
221+
dropdown: _subs
222222
options: '{{...}},${{ needs.pre.outputs.timestamp }}'
223223
description: '{...}\nUpdated ${{ needs.pre.outputs.timestamp }}'
224224
dry_run: no-push

README.md

+7-8
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Using a `template` is **suggested** for the following:
6464
```yaml template.yml
6565
...
6666
- type: dropdown
67-
id: $dropdown
67+
id: _dropdown
6868
description: 'template says: {...}, build says: ...'
6969
options:
7070
- a
@@ -76,7 +76,7 @@ Using a `template` is **suggested** for the following:
7676
```yaml workflow.yml
7777
...
7878
with:
79-
id: $dropdown
79+
id: _dropdown
8080
description: 'template says: {...}, build says: ...'
8181
options: {...}, b
8282
...
@@ -87,7 +87,7 @@ Using a `template` is **suggested** for the following:
8787
```yaml build.yml #1
8888
...
8989
with:
90-
id: $dropdown
90+
id: _dropdown
9191
description: 'template says: template says: {...}, build says: ..., build says: ...'
9292
options:
9393
- a
@@ -100,7 +100,7 @@ Using a `template` is **suggested** for the following:
100100
```yaml workflow.yml
101101
...
102102
with:
103-
id: $dropdown
103+
id: _dropdown
104104
description: 'template says: {{...}}, build says: ...'
105105
options: {{...}}, c
106106
...
@@ -111,7 +111,7 @@ Using a `template` is **suggested** for the following:
111111
```yaml build.yml #2
112112
...
113113
with:
114-
id: $dropdown
114+
id: _dropdown
115115
description: 'template says: template says: template says: {...}, build says: ..., build says: ..., build says: ...'
116116
options:
117117
- a
@@ -125,7 +125,7 @@ Using a `template` is **suggested** for the following:
125125
```yaml workflow.yml
126126
...
127127
with:
128-
id: $dropdown
128+
id: _dropdown
129129
description: 'template says: {{...}} but build says: ...'
130130
options: {...}, d
131131
...
@@ -136,7 +136,7 @@ Using a `template` is **suggested** for the following:
136136
```yaml build.yml #3
137137
...
138138
with:
139-
id: $dropdown
139+
id: _dropdown
140140
description: 'template says: template says: template says: template says: {...}, build says: ..., build says: ..., build says: ... but build says: ...'
141141
options:
142142
- a
@@ -166,4 +166,3 @@ Consider using [![create-pull-request](https://img.shields.io/github/v/release/p
166166

167167
Refer to the `update-long-report` job in [this workflow](.github/workflows/update_bug_report.yml) to see a usage example and to [PR #5](../../pull/5).\
168168
Don't forget to use the `dry_run` option.
169-

action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ inputs:
7373
description: |
7474
The prefix used by `strategy` to determine if a dropdown is dynamic
7575
type: string
76-
default: '$'
76+
default: _
7777
dry_run:
7878
description: |
7979
Pass `no-write` to leave `form` untouched

test/a.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 🧪 Test Form
22
title: 🧪 Test Form
33
body:
44
- type: dropdown
5-
id: $version
5+
id: _version
66
attributes:
77
label: version
88
description: Package version

test/attrs.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 🧪 Test Form
22
title: 🧪 Test Form
33
body:
44
- type: dropdown
5-
id: $version
5+
id: _version
66
attributes:
77
label: pip
88
description: foo bar

test/b.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 🧪 Test Form
22
title: 🧪 Test Form
33
body:
44
- type: dropdown
5-
id: $version
5+
id: _version
66
attributes:
77
label: version
88
description: Package version

test/dist.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 🧪 Test Form
22
title: 🧪 Test Form
33
body:
44
- type: dropdown
5-
id: $version
5+
id: _version
66
attributes:
77
label: version
88
description: Package version

test/expected.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 🧪 Test Form
22
title: 🧪 Test Form
33
body:
44
- type: dropdown
5-
id: $version
5+
id: _version
66
attributes:
77
label: version
88
description: Package version

0 commit comments

Comments
 (0)