Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline network call for user avatar #826

Open
pmarsh-scottlogic opened this issue Feb 6, 2024 · 0 comments
Open

Streamline network call for user avatar #826

pmarsh-scottlogic opened this issue Feb 6, 2024 · 0 comments
Labels
frontend Requires work on the frontend refactor Improve code quality

Comments

@pmarsh-scottlogic
Copy link
Contributor

If sending a message causes the use avatar to appear in the chat for the first time (even since resetting), we see a new network call to get the avatar assets/UserAvatar-b2331cdf.svg.

🔧 Could stop this? Cache it in the frontend somewhere? Presumably it's already being cached somehow because it doesn't get loaded for subsequent chat messages.

To replicate, open up the network tab in devtools. Send a message in a level. Observe the network call. Reset the level so that all messages are cleared. Send another message. Observe the new network call. Change to a different level that has a clear chat history. Send a message. Observe a further network call. All seems a bit wasteful to me.

@pmarsh-scottlogic pmarsh-scottlogic added frontend Requires work on the frontend refactor Improve code quality labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires work on the frontend refactor Improve code quality
Projects
None yet
Development

No branches or pull requests

1 participant