SLVUU-101 improve take screenshot functionality #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vferraro-scottlogic
requested review from
heswell,
pling-scottlogic and
cfisher-scottlogic
|
Could you add some static images of equivalent screenshots before and after the change, please? It's a bit tricky to evaluate from the gifs. |
pling-scottlogic
requested changes
Nov 29, 2023
vuu-ui/packages/vuu-shell/src/layout-management/SaveLayoutPanel.tsx
Outdated
Show resolved
Hide resolved
vuu-ui/packages/vuu-shell/src/layout-management/SaveLayoutPanel.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+13
to
+14
| child.nodeType === Node.TEXT_NODE || | ||
| child.getAttribute("role") !== "row", |
There was a problem hiding this comment.
These look like good filter criteria to me, but I'd like to know what @heswell thinks.
Here'a an example of the layout screenshot before and after the change: |
cfisher-scottlogic
approved these changes
Dec 5, 2023
pling-scottlogic
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an open BUG tracking this issue on the html-to-image repo. The following changes are aimed at mitigating the issue with the UI freezing when taking a screenshot of a very complex layout
Changes
Before
After
takeScreenshot function throws error (in this case the error is thrown because the layout is not displayed in the DOM)
Note
Filtering out the row elements means we won't be displaying the content of the tables inside the screenshot which could be a positive thing if we are worried about the data being sensitive
fix unit tests