plots autoresize; plus other fixes #39
Conversation
There was a problem hiding this comment.
Thanks for this! Aside from a few minor, it's great.
I agree, removing the file is unnecessary. Especially if we overwrite a file anyways. What do you think, @brentp? It's probably a good idea though to properly fix #20 soon though (I'll comment over there further).
removeFile should also be taken out for compilation with --threads:on, if we change it.
The resizing is really nice. I didn't know I wanted it until now. :) However, I'm not sure if we should default to this behavior. See the comment.
| }; | ||
| window.onresize = runRelayout; | ||
| # Consider: {responsive: true} | ||
| Plotly.newPlot('plot0', $data, $layout).then(runRelayout); |
There was a problem hiding this comment.
I would remove the <script> body from the defaultTmplString template, and create two different bodies. One with your JS code and one with the old one. Then the comments can just be normal Nim comments above the definition of that code and we can avoid the removeComments iteration.
Then add a field to Layout here: https://github.com/brentp/nim-plotly/blob/master/src/plotly/plotly_types.nim#L249. Maybe autoResize or something. Depending on its value either take your JS code or the old one. Then we can decide what we want to default to.
first thing I tried, but it didn't work; if you find a simpler way let me know :) |
* plots autoresize; plus other fixes * clean up some imports * [tests] fix API test due to chroma changes * split HTML template into resizable / non-resizable part * make auto resize user selectable, change HTML file location - allows the user to choose whether the plots should be automatically resized - allows the user to choose whether to remove the temporary file - cleans up the name for the arguments (i.e. override for temp file location & HTML template) - some doc string improvements * fix filling data into HTML template, remove nim comment * replace temp dir logic by single dir + multiple files Before it was many dirs with a single file each. This makes more sense and isn't as messy. * respect autoResize * update ubuntu image to make choosenim work Co-authored-by: Timothee Cour <[email protected]>
|
Closing in favor of #72. |
quitis nasty and shd rarely be used, see https://forum.nim-lang.org/t/4042 ; now; it'll just throw on error (and give the relevant path in exception msg)/cc @Vindaar @brentp
caveat: this will ignore given size settings; auto resize is a better default than a fixed arbitrary size, but we shd honor size if provided by user; let me know if u have a quick way to patch this PR to do that