Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Tables.jl impl, fall back to RecursiveArrayTools #813

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

AayushSabharwal
Copy link
Member

Close #798

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Oct 9, 2024

I think the isrowtable tests should have been removed with RAT@3, since the relevant documentation says:

Requirements for defining isrowtable include:

  • Tables.rows(x) === x, i.e. the table object itself is a Row iterator
  • If the table object is mutable, it should support:
    • push!(x, row): allow pushing a single row onto table
    • append!(x, rows): allow appending set of rows onto table
  • If table object is mutable and indexable, it should support:
    • x[i] = row: allow replacing of a row with another row by index

The third point is not valid for AbstractDiffEqArray

@ChrisRackauckas
Copy link
Member

good point

@ChrisRackauckas
Copy link
Member

There's no PR to RecursiveArrayTools though?

@AayushSabharwal
Copy link
Member Author

It already has the interface, and doesn't define isrowtable

@AayushSabharwal
Copy link
Member Author

In fact the code I removed here is almost identical to that in RAT

@ChrisRackauckas ChrisRackauckas merged commit a224914 into SciML:master Oct 9, 2024
25 of 43 checks passed
@AayushSabharwal AayushSabharwal deleted the as/rm-tabletraits branch October 9, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names of unknowns have a (t) appendix but DataFrame column names not
2 participants