Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Value type requirement from SampledIntegralProblem #498

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

IlianPihlajamaa
Copy link
Contributor

I found a way to make this Val type unnecessary. This makes the code simpler, type stable, and more performant for small problems.

Copy link
Contributor Author

@IlianPihlajamaa IlianPihlajamaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad... Thanks!

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #498 (819ec92) into master (8d293bf) will decrease coverage by 5.52%.
The diff coverage is 100.00%.

❗ Current head 819ec92 differs from pull request most recent head d70980e. Consider uploading reports for the commit d70980e to get more accurate results

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   57.65%   52.14%   -5.52%     
==========================================
  Files          50       50              
  Lines        3710     3709       -1     
==========================================
- Hits         2139     1934     -205     
- Misses       1571     1775     +204     
Files Changed Coverage Δ
src/problems/basic_problems.jl 89.47% <100.00%> (ø)

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@IlianPihlajamaa
Copy link
Contributor Author

How do I make sure the format check is successful?

@lxvm
Copy link
Contributor

lxvm commented Sep 20, 2023

How do I make sure the format check is successful?

See this https://docs.sciml.ai/SciMLStyle/stable/#JuliaFormatter

@ChrisRackauckas
Copy link
Member

I'll handle that later

@ChrisRackauckas ChrisRackauckas merged commit cb2f739 into SciML:master Sep 20, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants