Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: check if algorithm supports late binding tstops #1105

Merged
merged 4 commits into from
Nov 14, 2024
Merged

refactor: check if algorithm supports late binding tstops #1105

merged 4 commits into from
Nov 14, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as draft November 12, 2024 08:41
@AayushSabharwal
Copy link
Member Author

Draft while SciMLBase gets tagged

@AayushSabharwal AayushSabharwal marked this pull request as ready for review November 13, 2024 06:21
@AayushSabharwal
Copy link
Member Author

Actual failures:

All of these are also failures on master

@ChrisRackauckas ChrisRackauckas merged commit e2c83e9 into SciML:master Nov 14, 2024
24 of 44 checks passed
@AayushSabharwal AayushSabharwal deleted the as/late-tstops branch November 14, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AayushSabharwal @ChrisRackauckas @thazhemadam