Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check new remake version #1186

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Check new remake version #1186

wants to merge 6 commits into from

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented Feb 17, 2025

Updates conservation laws to work with new remake version.

@isaacsas
Copy link
Member

This is probably never going to pass tests with the change in semantics for complete. We can no longer rely on the parameters of a completed system being the same as what was defined when creating the system, which I think a lot of tests rely on.

@isaacsas
Copy link
Member

We can also no longer rely on issetequal(parmeters(sys), get_ps(sys)) for a flattened system.

@TorkelE
Copy link
Member Author

TorkelE commented Feb 18, 2025

Let's see how this turns out. If something like what you suggest is really changing it would be one of the largest changes to Catalyst ever, probably after moving to maps as inputs to problems. Would probably take ages to figure out all the implications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants