Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to add PEtab back #1090

Closed
wants to merge 2 commits into from
Closed

try to add PEtab back #1090

wants to merge 2 commits into from

Conversation

isaacsas
Copy link
Member

No description provided.

@isaacsas
Copy link
Member Author

isaacsas commented Oct 26, 2024

@TorkelE seems the tutorial needs updating to work with the latest PEtab.

@sebapersson
Copy link
Contributor

Something that might cause this issue is that with 3.0 I dropped on of the PEtabModel constructors. Specifically, simulation_conditions must always be provided as a keyword now:

PEtabModel(sys, observables, measurements, parameters; 
           simulation_conditions = simulation_conditions kwargs...)

More details on changed syntax can be found here

@TorkelE
Copy link
Member

TorkelE commented Oct 28, 2024

I have been meaning to try and remake and improve this one a bit, but might not have time to make it properly for a few weeks. Will try to fix so that it builds properly though.

@sebapersson
Copy link
Contributor

Thanks, happy to help if you encounter any problems!

@isaacsas
Copy link
Member Author

isaacsas commented Nov 1, 2024

I will close this for now since the tutorial needs updating, and whoever takes that on can open a new PR with their updates.

@isaacsas isaacsas closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants