Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hot-fix: dataset test returns code #122

Open
nitrosx opened this issue Jan 30, 2025 · 1 comment · May be fixed by #123
Open

hot-fix: dataset test returns code #122

nitrosx opened this issue Jan 30, 2025 · 1 comment · May be fixed by #123
Assignees
@YooSunYoung
Labels
bug Something isn't working urgent top priority

Comments

@nitrosx
Copy link
Member

nitrosx commented Jan 30, 2025

Currently the ingestor expect code 403 if the dataset does not exist when checking before creation.
The correct code is http status 404 (Not found).

It needs to be fixed in the following to locations:

scicat-ingestor/src/scicat_communication.py

Line 139 in db045cb

elif response.status_code == 403:

scicat-ingestor/src/scicat_communication.py

Line 182 in db045cb

elif response.status_code == 403:

@nitrosx nitrosx added bug Something isn't working urgent top priority labels Jan 30, 2025
@YooSunYoung
Copy link
Contributor

@nitrosx can it be fixed to be 204 No Content or something more specific?

@YooSunYoung YooSunYoung linked a pull request Jan 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YooSunYoung YooSunYoung

Labels
bug Something isn't working urgent top priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update filtering status code when file is not found. SciCatProject/scicat-ingestor
2 participants
@nitrosx @YooSunYoung