Skip to content

Commit b110fc0

Browse files
committed
[s1949] We centralized our issue tracking on cmangos/issues
All existing issues have been migrated to this centralized repository. As of now, we will deactivate the issue tracker on this repository and only use the new central one. Please note that Pull Requests are still on the repository containing the code and you'll still post them there, as they are directly associated with that code. Thanks to @github for making this possible with https://github.com/blog/1439-closing-issues-across-repositories [ci skip] (based on commit [12426] - e7ecc5f) Signed-off-by: DasBlub <[email protected]>
1 parent db047f1 commit b110fc0

File tree

3 files changed

+24
-21
lines changed

3 files changed

+24
-21
lines changed

CONTRIBUTING.md

+20-18
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ which is hosted at https://github.com/cmangos
1818

1919
* Make sure you have a [Forum account](http://cmangos.net)
2020
* Make sure you have a [GitHub account](https://github.com/signup/free)
21-
* Fork the CMaNGOS repository on Github (This way you will get informed about changes by github)
21+
* Watch the CMaNGOS repository on GitHub (This way you will get informed about changes by GitHub)
22+
* Optionally: Fork the CMaNGOS repository on GitHub in order to be able to publish own changes and create pull requests with them (see below for details)
2223

2324
You can help us developing the core by (at least!)
2425
* Giving Feedback on Bugs
@@ -27,7 +28,7 @@ You can help us developing the core by (at least!)
2728

2829
# Bug-Reports
2930

30-
If you spot a bug, you can either report it on our forums (cmangos.net) or by opening an issue in one of our github repositories.
31+
If you spot a bug, please report it by opening an issue on our centralized GitHub issue tracking repository: [cmangos/issues](https://github.com/cmangos/issues/issues).
3132
Before you do so, please consider the following points:
3233

3334
* The bug happens on a clean core
@@ -36,18 +37,18 @@ Before you do so, please consider the following points:
3637

3738
When you decide to create a new bug report, please make sure that this report includes:
3839

39-
* On which revision the bug happens
40-
* Revisions of additional parts of the CMaNGOS familiy (SD2-version, Database Name and Version, and such)
41-
* What you need to do do trigger the bug, be as detailed as possible.
42-
Please use spell-ids in your description, and try to use .cast commands to reproduce your bug. This makes reproducing much easier!
43-
* What IS happening WHEN doing your actions
44-
* What SHOULD happen when doing your actions - if possible also add a source why you think this should happen
45-
46-
* Please report only one bug per issue/thread!
40+
* Revision on which you encountered this bug (if known, also the revision or timeframe where it first appeared) - you can also post the link to the commit on the upstream repository
41+
* Revisions of additional parts of the CMaNGOS familiy (SD2 version, database name and version, and such)
42+
* A detailed step-by-step report how this bug can be reproduced
43+
* A detailed explenation of what DOES happen
44+
* A detailed explenation of what SHOULD happen - if possible also add a source why you think this should happen
45+
* When reporting spell-related bugs, please use spell-IDs in your description, and try to use .cast commands to reproduce your bug. This makes reproducing much easier!
46+
* When reporting crashes, please include a crash-log (as detailed as possible - we like GDB logs from debug builds!)
47+
* Only report one bug per issue/thread
4748

4849
# Testing features in development
4950
## Importing pull-requests
50-
Merging pull-requests into your branch for testing can be done by the GUIs provided by Github.
51+
Merging pull-requests into your branch for testing can be done by the GUIs provided by GitHub.
5152
For people not wanting to use them, we have a "MergeHelper.sh" script shipped in contrib/
5253

5354
You can - also on Windows within a Git Bash - start the script by using
@@ -67,7 +68,7 @@ which will simply merge pull-request 37 from your origin repository
6768

6869
This should be especially reasonable, if you yourself use topic branches like described in the next section!
6970

70-
Please be sure to feedback your test-results through proper channels -- this means commenting on the pull-requests, commenting on issues and commits on github.
71+
Please be sure to feedback your test-results through proper channels -- this means commenting on the pull-requests, commenting on issues and commits on GitHub.
7172

7273

7374
## Importing features from third-party repos
@@ -109,20 +110,21 @@ This code style is automatically enforced by the helper scripts in contrib/clean
109110

110111
You can publish and share your contribution projects via forum or by pull-requests
111112

112-
### Via Forum
113-
Using the our forum for sharing patches is perfectly fine, but for complicated features we strongly suggest to use topic branches and pull-requests
114-
If you want to use the forum, please consider _also_ [Forum Patch submission Guidelines](http://cmangos.net/thread-42.html)
115-
116-
### Via Pull-Requests on Github
117113
When you have created your topic-branch and pushed it to your local repository, you can easily create a pull-request to our repo from this!
114+
Please always create the pull request on the repository containing the CMaNGOS code you were working on.
118115

119-
Here is the [Github Information on Pull-Requests](https://help.github.com/articles/using-pull-requests)
116+
Here is the [GitHub Information on Pull-Requests](https://help.github.com/articles/using-pull-requests)
120117

121118
This has these advantages:
122119
* Your code will be read and commented on by many people
123120
* Your code will be fetched by people willing to help testing
124121
* Once you have opened a pull-request for a branch, every change of the branch (like a new commit) will automatically be added to the pull-request.
125122
So you won't have any additional overhead in maintaining the pull-request :)
123+
* Travis CI will automatically test the build of your pull request and report the status just as it does for our commits
124+
125+
If it is only a minor change and you do not want to create a topic-branch and a pull request (though you should, it's fast and easy to do!),
126+
you can also open a normal issue and paste the diff in there (but please use the Markdown tags to mark it as a code!). Rule of thumb is that
127+
more than 20 lines should most definitely be posted as a pull request instead of an issue with a simple diff.
126128

127129
# Additional Resources
128130

README.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,10 @@ To be able to accomplish these goals, we support and promote:
5353
* [CMaNGOS Forum](http://cmangos.net/)
5454
* CMaNGOS IRC channel: #cmangos on irc.rizon.net
5555
* [GitHub repositories](https://github.com/cmangos/)
56-
* [Issue tracker](https://github.com/cmangos/mangos-tbc/issues)
56+
* [Issue tracker](https://github.com/cmangos/issues/issues)
57+
* [Pull Requests](https://github.com/cmangos/mangos-tbc/pulls)
5758
* [Current build status on Travis CI](https://travis-ci.org/cmangos/mangos-tbc/)
58-
* [Wiki](https://github.com/cmangos/mangos-tbc/wiki) with additional information on installation
59+
* [Wiki](https://github.com/cmangos/issues/wiki) with additional information on installation
5960
* Documentation can be found in the doc/ subdirectory and on the github wiki
6061

6162
## License

src/shared/revision_nr.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
#ifndef __REVISION_NR_H__
22
#define __REVISION_NR_H__
3-
#define REVISION_NR "1948"
3+
#define REVISION_NR "1949"
44
#endif // __REVISION_NR_H__

0 commit comments

Comments
 (0)