Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdfx] Update to device_info_plus >= 10.0.1 #501

Open
stsc3000 opened this issue Apr 3, 2024 · 15 comments
Open

[pdfx] Update to device_info_plus >= 10.0.1 #501

stsc3000 opened this issue Apr 3, 2024 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@stsc3000
Copy link

stsc3000 commented Apr 3, 2024

Is your feature request related to a problem? Please describe.
Apple has listed device_info_plus as a privacy impacting SDK which will require a privacy manifest and signature. The device_info_plus maintainers have added an (empty) Privacy Manifest in 10.0.1.
It is, at least to my knowledge, unclear when Apple will start enforcing the presence of the manifests (other than required reason APIs need to be included until May 1st 2024 - which device_info_plus does not use).

Describe the solution you'd like
Update the device_info_plus dependency.

Describe alternatives you've considered

  • Use less strict version requirements for the dependency.
  • As far as I can see it is only used for the Android sdkInt. Alternatively the dependency could be dropped altogether and the value could be fetched via native code.

Additional context
The device_info_plus changelog indicates updated requirements for Android and Flutter:

  • Flutter >=3.19.0
  • Dart >=3.3.0
  • compileSDK 34 for Android part
  • Java 17 for Android part
  • Gradle 8.4 for Android part

I guess Flutter and Dart should be updated in the pdfxs pubspec.yaml, however I'm not sure how the other updates would need to be applied to the plugin, if at all.

@stsc3000 stsc3000 added the enhancement New feature or request label Apr 3, 2024
@stsc3000 stsc3000 changed the title Update to device_info_plus >= 10.0.1 [pdfx] Update to device_info_plus >= 10.0.1 Apr 5, 2024
@command-not-found
Copy link

+1

@NashIlli
Copy link

+1

@ManuelRauber
Copy link

@SergeShkurko This is some kind of important, would be nice if it can get your attention.

@tuanha21
Copy link

+1

@sebastianolaru3008
Copy link

@SergeShkurko I hope this can get on your radar. It became a rly needed enhancement. Please take a look into it.

@BohdanSamusko
Copy link

+1

3 similar comments
@NashIlli
Copy link

+1

@Paroca72
Copy link

+1

@stan-at-work
Copy link

+1

@stan-at-work
Copy link

@SergeShkurko Could you add a second maintainer, someone that is actually active on the project ?

@stonymahony
Copy link

Someone already made a MR #506 waiting for approval.. 🙂

@emakar
Copy link
Contributor

emakar commented Jun 27, 2024

it's already ^10, no need to specify minor version (e.g. ^10.1)
what's needed - is to publish pdfx update (e.g. 2.7.0)

@stan-at-work
Copy link

...

@rivella50
Copy link

Serge hasn't committed anything since end of April. Doesn't sound well.
Is there someone else who could perform that release or temporarily takeover the project?

@stan-at-work
Copy link

i switched to pdfrx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests