Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector position failure in rare cases. #6

Closed
mitu-lv opened this issue Oct 23, 2020 · 5 comments
Closed

Connector position failure in rare cases. #6

mitu-lv opened this issue Oct 23, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@mitu-lv
Copy link

mitu-lv commented Oct 23, 2020

graph
Tried it with really large set of nodes, connectors at one only one point failed to draw correctly.
682 and 78 are children of 684 and 685. 684 however has two spouses 685 and 76.

big-sample.zip

Tried it with sample code from this node
const data: { [key: string]: any[] } = { '285': bigSample, };

Maybe author has an idea what would be wrong with data?
Or maybe it is a bug?

@SanichKotikov
Copy link
Owner

Looks like a bug. I will look into.

@SanichKotikov SanichKotikov added the bug Something isn't working label Oct 24, 2020
@SanichKotikov
Copy link
Owner

Published v2.1.0. @mitu-lv can you check it?

@mitu-lv
Copy link
Author

mitu-lv commented Oct 25, 2020

Sure @SanichKotikov!

@mitu-lv
Copy link
Author

mitu-lv commented Oct 25, 2020

image
That issue is fixed now, but the beginning of example is drawn out of canvas :(
First node that is drawn is not the left most in example.

@SanichKotikov
Copy link
Owner

That issue is fixed now

Nice! Thanks.

but the beginning of example is drawn out of canvas :(
First node that is drawn is not the left most in example.

This is a browser's limitation https://developer.mozilla.org/en-US/docs/Web/HTML/Element/canvas#Maximum_canvas_size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants