Skip to content

Commit 7b46fea

Browse files
committed
update advancing threshold
1 parent 1770bfb commit 7b46fea

File tree

2 files changed

+8
-44
lines changed

2 files changed

+8
-44
lines changed

UPGRADE.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
2+
* configure .env
3+
* old node version; use `sudo n` to change a relevant version like 8.9.4
4+
* start database:
5+
* start docker daemon (os x)
6+
* `docker run -p 27017:27017 mongo`

packages/portal/backend/src/custom/CustomCourseController.ts

+2-44
Original file line numberDiff line numberDiff line change
@@ -21,49 +21,7 @@ import {Deliverable, Grade, Person, PersonKind, Repository, Team} from "../Types
2121
*/
2222
export class CustomCourseController extends CourseController {
2323

24-
// /**
25-
// * Public static so tests can use them too.
26-
// *
27-
// * @returns {string}
28-
// */
29-
// public static getProjectPrefix(): string {
30-
// const name = Config.getInstance().getProp(ConfigKey.name);
31-
// if (name === ConfigCourses.classytest) {
32-
// Log.info("CustomCourseController::getProjectPrefix(..) - returning test prefix");
33-
// return "TEST__X__p_";
34-
// } else if (name === 'sdmm') {
35-
// Log.trace("CustomCourseController::getProjectPrefix(..) - returning sdmm prefix");
36-
// return "secap_";
37-
// } else {
38-
// // NOTE: non-sdmm courses shouldn't use this...
39-
// Log.error("CustomCourseController::getProjectPrefix(..) - unhandled course: " + name);
40-
// return "project_";
41-
// }
42-
// }
43-
44-
// /**
45-
// * Public static so tests can use them too.
46-
// *
47-
// * @returns {string}
48-
// */
49-
// public static getTeamPrefix() {
50-
// const name = Config.getInstance().getProp(ConfigKey.name);
51-
//
52-
// if (name === ConfigCourses.classytest) {
53-
// Log.info("CustomCourseController::getTeamPrefix(..) - returning test prefix");
54-
// return "TEST__X__t_";
55-
// } else if (name === 'sdmm') {
56-
// Log.trace("CustomCourseController::getTeamPrefix(..) - returning sdmm prefix");
57-
// // NOTE: was supposed to be "t_" but we made a mistake in initial deployment so we're stuck with no prefix
58-
// return "";
59-
// } else {
60-
// // NOTE: non-sdmm courses shouldn't use this...
61-
// Log.error("CustomCourseController::getTeamPrefix(..) - unhandled course: " + name);
62-
// return "t_";
63-
// }
64-
// }
65-
66-
private GRADE_TO_ADVANCE = 80;
24+
private GRADE_TO_ADVANCE = 60; // threshold to move between deliverables
6725

6826
public static readonly D0 = 'd0';
6927
public static readonly D1 = 'd1';
@@ -812,7 +770,7 @@ export class CustomCourseController extends CourseController {
812770

813771
// // seems complicated, but we need team names that are unique
814772
// // but with lots of people signing up at once we can't rely on a counter
815-
// // especially since full provisioning will take a long time (e.g., GRADE_TO_ADVANCE+ seconds)
773+
// // especially since full provisioning will take a long time
816774
// let teamName: string | null = null;
817775
// while (teamName === null) {
818776
// let str = crypto.randomBytes(256).toString('hex');

0 commit comments

Comments
 (0)