Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-side-navigation]: Arrows don't work for navigation in the overflow sub-menu #10933

Closed
1 task done
LidiyaGeorgieva opened this issue Feb 24, 2025 · 2 comments · Fixed by #11129
Closed
1 task done

[ui5-side-navigation]: Arrows don't work for navigation in the overflow sub-menu #10933

LidiyaGeorgieva opened this issue Feb 24, 2025 · 2 comments · Fixed by #11129
Assignees
@tsanislavgatev
Labels
bug This issue is a bug in the code released TOPIC B

Comments

@LidiyaGeorgieva
Copy link
Contributor

Bug Description

https://sap.github.io/ui5-webcomponents/nightly/components/fiori/SideNavigation/#basic-sample

Add "collapsed" attribute to the Side Navigation and add more items to see the overflow.

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

No response

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@LidiyaGeorgieva LidiyaGeorgieva added bug This issue is a bug in the code TOPIC RD labels Feb 24, 2025
@dimovpetar dimovpetar self-assigned this Mar 10, 2025
@dimovpetar
Copy link
Contributor

Hello colleagues,

In Menu.ts, there is this check

ui5-webcomponents/packages/main/src/Menu.ts

Line 364 in de6e614

if (item.hasAttribute("ui5-menu-item")) {

In this case, the item doesn't have "ui5-menu-item" attribute, because it's a subclass of MenuItem. Therefore, I think that check for MenuItem should be adjusted. Something like the implementation of instanceOfUI5Element.

To reproduce the issue:

  1. Open link
  2. Click on the overflow icon (...)
  3. Click on "People"
  4. Try to navigate with "Arrow down".
  5. Observe the error in the console

@dimovpetar dimovpetar removed their assignment Mar 10, 2025
@tsanislavgatev tsanislavgatev self-assigned this Mar 17, 2025
@tsanislavgatev tsanislavgatev mentioned this issue Mar 18, 2025
Merged
@tsanislavgatev tsanislavgatev moved this from New Issues to In Progress in Maintenance - Topic B Mar 18, 2025
tsanislavgatev added a commit that referenced this issue Mar 19, 2025
@tsanislavgatev
fix(ui5-menu): fix menu item type fix (#11129)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
3e68c57 
Before:
When used in SideNavigation, the item doesn't have "ui5-menu-item" attribute, because it's a subclass of MenuItem and the navigation checks are failing.

After:
We check with a getter done in the MenuItem class, so even if the class is extended, we will have the correct results in these checks.

fixes: #10933
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic B Mar 19, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.9.0-rc.1 🎉

The release is available on v2.9.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsanislavgatev tsanislavgatev

Labels
bug This issue is a bug in the code released TOPIC B
Projects
Maintenance - Topic B
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-menu): fix menu item type fix SAP/ui5-webcomponents
4 participants
@LidiyaGeorgieva @tsanislavgatev @dimovpetar @ui5-webcomponents-bot