Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input | icons ]: When Input component of type password shows duplicate icon in Edge broswer #11083

Closed
1 task done
yoganjan opened this issue Mar 13, 2025 · 3 comments · Fixed by #11114
Closed
1 task done

[Input | icons ]: When Input component of type password shows duplicate icon in Edge broswer #11083

yoganjan opened this issue Mar 13, 2025 · 3 comments · Fixed by #11114
Assignees
@ivoplashkov
Labels
bug This issue is a bug in the code for discussion released TOPIC RL

Comments

@yoganjan
Copy link

Bug Description

When Input component is used as Password with custom icon name show / hide , We see 2 icons in the Edge Browser.

Affected Component

Input

Expected Behaviour

We should not be seeing duplicate icons

Isolated Example

No response

Steps to Reproduce

  1. Use the Edge Browser
  2. Navigate to Input Component
  3. Set the type as password
  4. Give the icon name as "Hide / Show"
  5. Observe that we have 2 eye icons
    https://sap.github.io/ui5-webcomponents-react/v2/?path=/story/inputs-input--default&args=type:Password;valueState:None2.

Log Output, Stack Trace or Screenshots

Image

Priority

None

UI5 Web Components Version

v2

Browser

Edge

Operating System

Mac / Windows

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@yoganjan yoganjan added the bug This issue is a bug in the code label Mar 13, 2025
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-assigned this Mar 13, 2025
@PetyaMarkovaBogdanova
Copy link
Contributor

Hi colleagues from @SAP/ui5-webcomponents-topic-rl ,
the situation can be reproduced here. /in Edge browser/
There is a CSS style that can easily remove the Edge hide/show native icon:
[inner-input]::-ms-reveal, [inner-input]::-ms-clear { display: none; }

can you, please, consider if that enhancement is needed and this finding can be treated as an issue?
Best regards,
Petya Markova.
UI5 Web Components Dispatcher

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova removed their assignment Mar 13, 2025
@yoganjan
Copy link
Author

Hi @PetyaMarkovaBogdanova ,
We tried this below solution , but it did not work . 2 Eye icons were still showing up in EDGE browser

[inner-input]::-ms-reveal, [inner-input]::-ms-clear { display: none; }

Thanks,
Yoganjan

@ivoplashkov ivoplashkov self-assigned this Mar 17, 2025
@ivoplashkov ivoplashkov moved this from New Issues to In progress in Maintenance - Topic RL Mar 17, 2025
@ivoplashkov ivoplashkov mentioned this issue Mar 17, 2025
Merged
@github-project-automation github-project-automation bot moved this from In progress to Completed in Maintenance - Topic RL Mar 21, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.9.0-rc.2 🎉

The release is available on v2.9.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivoplashkov ivoplashkov

Labels
bug This issue is a bug in the code for discussion released TOPIC RL
Projects
Maintenance - Topic RL
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-input): remove additional icon in Edge SAP/ui5-webcomponents
4 participants
@PetyaMarkovaBogdanova @yoganjan @ivoplashkov @ui5-webcomponents-bot