Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DynamicPageTitle, Toolbar]: A11y: Count of number of items in overflow popover not read by screen readers #11053

Open
1 task done
abhijeet181088 opened this issue Mar 10, 2025 · 2 comments
Labels
ACC enhancement New feature or request TOPIC P

Comments

@abhijeet181088
Copy link

Describe the bug

Hi, The issue mentioned in SAP/ui5-webcomponents-react#5926 seems to be partially fixed in the V2 of UI5 webcomponents for react.

For independent toolbar we can see count is being read now. But for the toolbar within the DynamicPageTitle, this still seems to be missing. It is reproducible on the documentation page of the DynamicPage: https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/layouts-floorplans-dynamicpage--docs

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/layouts-floorplans-dynamicpage--docs

Reproduction steps

Toolbar used internally by DynamicPageTitle does not read the count of items in overflow menu.

Expected Behaviour

Overflow popover menu of the toolbar within the DynamicPageTitle should read the number of items in it.

Screenshots or Videos

Image

UI5 Web Components for React Version

2.5.0

UI5 Web Components Version

2.5.0

Browser

Edge

Operating System

Windows

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Collaborator

Lukas742 commented Mar 11, 2025

Hi @abhijeet181088

the linked issue refers to v1 of ui5-webcomponents-react, so it only fixed a bug in the v1 Toolbar developed in this repo (React only component), not the v2 Toolbar developed in the ui5-webcomponents repo (web component). We ported the fix to the V2 compat package where the "old" toolbar is still available.

In V1 the DynamicPage is also a React only component, whereas in V2 it was replaced by a web component.

For independent toolbar we can see count is being read now.

Please make sure to always define to which Toolbar you are referring. Do you mean the Toolbar from the main or compat package?

Since in V2, the DynamicPage and the Toolbar used inside the DynamicPage are both web components developed by the ui5-webcomponents team, I'm going to forward this issue to their repo.


Hi Colleagues,

could you please take over?

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Mar 11, 2025
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-assigned this Mar 11, 2025
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova added enhancement New feature or request ACC labels Mar 11, 2025
@PetyaMarkovaBogdanova
Copy link
Contributor

Hi colleagues from @SAP/ui5-webcomponents-topic-p ,
In the screen reader specification, also in OpenUI5 OverflowToolbar control there is no rule for the "count" of the items to be read out, when opening the Popover (in the case of Dynamic Page - in actions area). Although in the List screen reader specification there is a rule saying "Item count and item position must be provided using aria-posinset and aria-setsize" and maybe we can consider adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACC enhancement New feature or request TOPIC P
Projects
Development

No branches or pull requests

3 participants