Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-view-settings-dialog]: missing context on numbers used in filter option #11040

Closed
1 task done
nnaydenow opened this issue Mar 7, 2025 · 0 comments · Fixed by #11042
Closed
1 task done

[ui5-view-settings-dialog]: missing context on numbers used in filter option #11040

nnaydenow opened this issue Mar 7, 2025 · 0 comments · Fixed by #11042
Assignees
Labels
bug This issue is a bug in the code TOPIC B

Comments

@nnaydenow
Copy link
Contributor

Bug Description

When filter provides multiple options and they are selected, number appears at the end. When the filter is accessed with keyboard and active screen reader only number is read.

For example:

List text 5

Affected Component

No response

Expected Behaviour

Some additional content to be provided in order to make these numbers more meaningful.

For example:

List text, 5 selected filters

Isolated Example

https://sap.github.io/ui5-webcomponents/nightly/play/#eyJpbmRleC5odG1sIjp7Im5hbWUiOiJpbmRleC5odG1sIiwiY29udGVudCI6IjwhLS0gcGxheWdyb3VuZC1mb2xkIC0tPlxuPCFET0NUWVBFIGh0bWw-XG48aHRtbCBsYW5nPVwiZW5cIj5cblxuXG5cbjxoZWFkPlxuICAgIFxuICAgIDxzdHlsZT5cbiAgICAgICo6bm90KDpkZWZpbmVkKSB7XG4gICAgICAgIGRpc3BsYXk6IG5vbmU7XG4gICAgICB9XG5cbiAgICBodG1sIHtcbiAgICAgIGZvcmNlZC1jb2xvci1hZGp1c3Q6IG5vbmU7XG4gICAgfVxuICAgIDwvc3R5bGU-XG5cbiAgICBcbiAgICA8c3R5bGU-XG4gICAgICAqOm5vdCg6ZGVmaW5lZCkge1xuICAgICAgICBkaXNwbGF5OiBub25lO1xuICAgICAgfVxuXG4gICAgaHRtbCB7XG4gICAgICBmb3JjZWQtY29sb3ItYWRqdXN0OiBub25lO1xuICAgIH1cbiAgICA8L3N0eWxlPlxuXG4gICAgPG1ldGEgY2hhcnNldD1cIlVURi04XCI-XG4gICAgPG1ldGEgbmFtZT1cInZpZXdwb3J0XCIgY29udGVudD1cIndpZHRoPWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLjBcIj5cbiAgICA8dGl0bGU-U2FtcGxlPC90aXRsZT5cbjwvaGVhZD5cblxuPGJvZHkgc3R5bGU9XCJiYWNrZ3JvdW5kLWNvbG9yOiB2YXIoLS1zYXBCYWNrZ3JvdW5kQ29sb3IpOyBoZWlnaHQ6IDQwMHB4O1wiPlxuICAgIDwhLS0gcGxheWdyb3VuZC1mb2xkLWVuZCAtLT5cblxuICAgIDx1aTUtYnV0dG9uIGlkPVwiYnRuT3BlbkRpYWxvZzFcIj5PcGVuIFZpZXdTZXR0aW5nc0RpYWxvZzwvdWk1LWJ1dHRvbj5cblxuICAgIDx1aTUtdmlldy1zZXR0aW5ncy1kaWFsb2cgaWQ9XCJ2c2QxXCIgc29ydC1kZXNjZW5kaW5nPlxuICAgICAgICA8dWk1LWZpbHRlci1pdGVtIHNsb3Q9XCJmaWx0ZXJJdGVtc1wiIHRleHQ9XCJQb3NpdGlvblwiPlxuICAgICAgICAgICAgPHVpNS1maWx0ZXItaXRlbS1vcHRpb24gc2xvdD1cInZhbHVlc1wiIHRleHQ9XCJDVE9cIj48L3VpNS1maWx0ZXItaXRlbS1vcHRpb24-XG4gICAgICAgICAgICA8dWk1LWZpbHRlci1pdGVtLW9wdGlvbiBzbG90PVwidmFsdWVzXCIgdGV4dD1cIkNQT1wiPjwvdWk1LWZpbHRlci1pdGVtLW9wdGlvbj5cbiAgICAgICAgICAgIDx1aTUtZmlsdGVyLWl0ZW0tb3B0aW9uIHNsb3Q9XCJ2YWx1ZXNcIiB0ZXh0PVwiVlBcIj48L3VpNS1maWx0ZXItaXRlbS1vcHRpb24-XG4gICAgICAgIDwvdWk1LWZpbHRlci1pdGVtPlxuICAgICAgICA8dWk1LWZpbHRlci1pdGVtIHNsb3Q9XCJmaWx0ZXJJdGVtc1wiIHRleHQ9XCJEZXBhcnRtZW50XCI-XG4gICAgICAgICAgICA8dWk1LWZpbHRlci1pdGVtLW9wdGlvbiBzbG90PVwidmFsdWVzXCIgdGV4dD1cIlNhbGVzXCI-PC91aTUtZmlsdGVyLWl0ZW0tb3B0aW9uPlxuICAgICAgICAgICAgPHVpNS1maWx0ZXItaXRlbS1vcHRpb24gc2xvdD1cInZhbHVlc1wiIHRleHQ9XCJNYW5hZ2VtZW50XCI-PC91aTUtZmlsdGVyLWl0ZW0tb3B0aW9uPlxuICAgICAgICAgICAgPHVpNS1maWx0ZXItaXRlbS1vcHRpb24gc2xvdD1cInZhbHVlc1wiIHRleHQ9XCJQUlwiPjwvdWk1LWZpbHRlci1pdGVtLW9wdGlvbj5cbiAgICAgICAgPC91aTUtZmlsdGVyLWl0ZW0-XG4gICAgICAgIDx1aTUtZmlsdGVyLWl0ZW0gc2xvdD1cImZpbHRlckl0ZW1zXCIgdGV4dD1cIkxvY2F0aW9uXCI-XG4gICAgICAgICAgICA8dWk1LWZpbHRlci1pdGVtLW9wdGlvbiBzbG90PVwidmFsdWVzXCIgdGV4dD1cIldhbGxkb3JmXCI-PC91aTUtZmlsdGVyLWl0ZW0tb3B0aW9uPlxuICAgICAgICAgICAgPHVpNS1maWx0ZXItaXRlbS1vcHRpb24gc2xvdD1cInZhbHVlc1wiIHRleHQ9XCJOZXcgWW9ya1wiPjwvdWk1LWZpbHRlci1pdGVtLW9wdGlvbj5cbiAgICAgICAgICAgIDx1aTUtZmlsdGVyLWl0ZW0tb3B0aW9uIHNsb3Q9XCJ2YWx1ZXNcIiB0ZXh0PVwiTG9uZG9uXCI-PC91aTUtZmlsdGVyLWl0ZW0tb3B0aW9uPlxuICAgICAgICA8L3VpNS1maWx0ZXItaXRlbT5cbiAgICAgICAgPHVpNS1maWx0ZXItaXRlbSBzbG90PVwiZmlsdGVySXRlbXNcIiB0ZXh0PVwiUmVwb3J0cyB0b1wiPlxuICAgICAgICAgICAgPHVpNS1maWx0ZXItaXRlbS1vcHRpb24gc2xvdD1cInZhbHVlc1wiIHRleHQ9XCJDVE9cIj48L3VpNS1maWx0ZXItaXRlbS1vcHRpb24-XG4gICAgICAgICAgICA8dWk1LWZpbHRlci1pdGVtLW9wdGlvbiBzbG90PVwidmFsdWVzXCIgdGV4dD1cIkNQT1wiPjwvdWk1LWZpbHRlci1pdGVtLW9wdGlvbj5cbiAgICAgICAgICAgIDx1aTUtZmlsdGVyLWl0ZW0tb3B0aW9uIHNsb3Q9XCJ2YWx1ZXNcIiB0ZXh0PVwiVlBcIj48L3VpNS1maWx0ZXItaXRlbS1vcHRpb24-XG4gICAgICAgIDwvdWk1LWZpbHRlci1pdGVtPlxuICAgIDwvdWk1LXZpZXctc2V0dGluZ3MtZGlhbG9nPlxuICAgIDxiciAvPlxuICAgIDxiciAvPlxuICAgIDxkaXYgaWQ9XCJ2c2RSZXN1bHRzXCI-PC9kaXY-XG4gICAgPCEtLSBwbGF5Z3JvdW5kLWZvbGQgLS0-XG4gICAgPHNjcmlwdCB0eXBlPVwibW9kdWxlXCIgc3JjPVwibWFpbi5qc1wiPjwvc2NyaXB0PlxuPC9ib2R5PlxuXG48L2h0bWw-XG48IS0tIHBsYXlncm91bmQtZm9sZC1lbmQgLS0-XG4ifSwibWFpbi5qcyI6eyJuYW1lIjoibWFpbi5qcyIsImNvbnRlbnQiOiIvKiBwbGF5Z3JvdW5kLWhpZGUgKi9cbmltcG9ydCBcIi4vcGxheWdyb3VuZC1zdXBwb3J0LmpzXCI7XG4vKiBwbGF5Z3JvdW5kLWhpZGUtZW5kICovXG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMvZGlzdC9CdXR0b24uanNcIjtcblxuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzLWZpb3JpL2Rpc3QvVmlld1NldHRpbmdzRGlhbG9nLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMtZmlvcmkvZGlzdC9Tb3J0SXRlbS5qc1wiO1xuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzLWZpb3JpL2Rpc3QvRmlsdGVySXRlbS5qc1wiO1xuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzLWZpb3JpL2Rpc3QvRmlsdGVySXRlbU9wdGlvbi5qc1wiO1xuXG52YXIgdnNkUmVzdWx0cyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKFwidnNkUmVzdWx0c1wiKTtcblxuYnRuT3BlbkRpYWxvZzEuYWRkRXZlbnRMaXN0ZW5lcihcImNsaWNrXCIsIGZ1bmN0aW9uICgpIHtcbiAgICB2c2RSZXN1bHRzLmlubmVySFRNTCA9IFwiXCI7XG4gICAgdnNkMS5vcGVuID0gdHJ1ZTtcbn0pO1xuXG52c2QxLmFkZEV2ZW50TGlzdGVuZXIoXCJjb25maXJtXCIsIGZ1bmN0aW9uIChldnQpIHtcbiAgICB2c2RSZXN1bHRzLmlubmVySFRNTCA9IEpTT04uc3RyaW5naWZ5KGV2dC5kZXRhaWwpO1xufSk7In19

Steps to Reproduce

  1. Open VSD
  2. Click Position filter
  3. Select filter items
  4. Return to previous tab
  5. listen the output from screenreaders
    ...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

nightly

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nnaydenow nnaydenow added bug This issue is a bug in the code TOPIC B labels Mar 7, 2025
@unazko unazko self-assigned this Mar 9, 2025
@unazko unazko moved this from New Issues to In Progress in Maintenance - Topic B Mar 9, 2025
@unazko unazko closed this as completed in a6a86e8 Mar 24, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic B Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC B
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants