Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MenuItem]: 'role' does not exist in type 'ListItemAccessibilityAttributes' #10981

Closed
1 task done
AlekseiSch opened this issue Feb 28, 2025 · 2 comments
Closed
1 task done

[MenuItem]: 'role' does not exist in type 'ListItemAccessibilityAttributes' #10981

AlekseiSch opened this issue Feb 28, 2025 · 2 comments
Assignees
@tsanislavgatev
Labels
bug This issue is a bug in the code Medium Prio TOPIC B

Comments

@AlekseiSch
Copy link

AlekseiSch commented Feb 28, 2025 •
edited
Loading

Bug Description

Observed Behavior:
I've added accessibilityAttributes in accordance with the documentation and got a type error 'role' does not exist in type 'ListItemAccessibilityAttributes'. ts(2353).

https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/modals-popovers-menu--docs

Code fragment:

Image

Affected Component

MenuItem

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.7.2

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@AlekseiSch AlekseiSch added the bug This issue is a bug in the code label Feb 28, 2025
@TeodorTaushanov
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-b, can you check this issue?

@tsanislavgatev tsanislavgatev mentioned this issue Mar 7, 2025
Merged
@unazko unazko self-assigned this Mar 9, 2025
tsanislavgatev added a commit that referenced this issue Mar 10, 2025
@tsanislavgatev
docs(ui5-menu-item): update accessibilityAttributes documentation (#1…
f8df44f 
…1036)

related to: #10981

After we merge this we will have to wait for this so it can take effect, because currently declare only applies the JSDoc override, but not the type itself.
@unazko unazko removed their assignment Mar 10, 2025
@tsanislavgatev
Copy link
Contributor

Hi @AlekseiSch ,

This issue will be fixed when this is closed: #11041

Please follow the development in the provided issue, as it is a functionality that should be enabled on framework level.

Thanks and Best Regards,
Tsanislav

@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic B Mar 19, 2025
@tsanislavgatev tsanislavgatev self-assigned this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsanislavgatev tsanislavgatev

Labels
bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Maintenance - Topic B
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TeodorTaushanov @tsanislavgatev @unazko @AlekseiSch