Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals: flickering position #10211

Closed
1 task done
tkeiner opened this issue Nov 18, 2024 · 2 comments
Closed
1 task done

Modals: flickering position #10211

tkeiner opened this issue Nov 18, 2024 · 2 comments
Assignees
Labels
bug This issue is a bug in the code duplicate This issue or pull request already exists

Comments

@tkeiner
Copy link

tkeiner commented Nov 18, 2024

Describe the bug

On rendering of a Modal component (e.g. Toast or MessageBox) the position of the component is not fixed, which makes it look like the component flickers into the screen.

This behaviour does not always occur but is easily reproducible by opening a Modal multiple times and changing the width of the screen between render.

Isolated Example

https://stackblitz.com/edit/github-d34zwy?file=src%2FApp.tsx

Reproduction steps

  1. Create Modal Component
  2. Trigger Modal Component to open

Expected Behaviour

Ideally the Component should be rendered at the correct position without a change position being noticeable by a human.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.4.0

UI5 Web Components Version

2.4.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@tkeiner tkeiner added the bug This issue is a bug in the code label Nov 18, 2024
@Lukas742
Copy link
Collaborator

Hi @tkeiner

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi Colleagues,

this issue is basically the same as described in this issue. So, please feel free to close this one as duplicate.
It seems that the issue affects all popup components extending the Popup class that are conditionally rendered.

Our Modals provider, conditionally renders the respective component with open="true" as default value, so developers can open popups without having to create a dedicated component for each popup. You can find out more about this in our Storybook.

In case you need a reproducible example without our Modals class, our wrapper or React, please let me know.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Nov 19, 2024
@ivoplashkov ivoplashkov self-assigned this Nov 19, 2024
@ivoplashkov
Copy link
Member

Hello @tkeiner,

Thank you for reaching out.

Indeed the issue is basically the same as the one mentioned in the above reply. It is reproducible with all popup components even without the Modals provider - https://stackblitz.com/edit/github-8upxfb-ndn9tp?file=index.html,main.js.

I am closing this issue as a duplicate, therefore please track the progress there.

Kind regards,
Ivaylo

@ivoplashkov ivoplashkov added the duplicate This issue or pull request already exists label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code duplicate This issue or pull request already exists
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants